This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
patch in ada-tasks needs small fix (was: "New ARI warning Fri Feb 24 01:54:10 UTC 2012")
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Tristan Gingold <gingold at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 24 Feb 2012 05:40:32 -0800
- Subject: patch in ada-tasks needs small fix (was: "New ARI warning Fri Feb 24 01:54:10 UTC 2012")
- References: <20120224015410.GA23561@sourceware.org>
Hi Tristan,
On Fri, Feb 24, 2012 at 01:54:10AM +0000, GDB Administrator wrote:
> 5a6
> > gdb/ada-tasks.c:881: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
> gdb/ada-tasks.c:881: if (TYPE_CODE (type) == TYPE_CODE_ARRAY && (eltype = check_typedef (TYPE_TARGET_TYPE (type))) && TYPE_CODE (eltype) == TYPE_CODE_PTR && (idxtype = check_typedef (TYPE_INDEX_TYPE (type))) && !TYPE_LOW_BOUND_UNDEFINED (idxtype) && !TYPE_HIGH_BOUND_UNDEFINED (idxtype))
This one is for us. I confess I hadn't noticed the assignments in
the condition, but they are indeed. I think we can rewrite the code
relatively easily without too much change in the program structure.
Would you take a look at that? If you don't get to it today, then
I will try to have a look at it.
Thanks,
--
Joel