This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR server/9684: gdbserver, attach to stopped processes


On 02/24/2012 11:00 PM, Joel Brobecker wrote:
>> I'm a bit ambivalent on this.  I found out that this isn't actually
>> necessary on recent kernels (I haven't looked for the exact version or
>> commit that made it so) -- waitpid no longer hangs.  OTOH, we still
>> need it on systems with not so recent kernels where support is still
>> well active, so I figure this may be useful to many upstream as well.
> 
> FWIW, I tend to agree. If it is possibly useful to others, and it's
> not intrusive, it is all good reasons for the patch to go in. I took
> a look just to have an idea of what it's about, and it seems like
> a reasonably uninvasive patch...

Thanks for weighing in.

> As always, I always marvel at the beautiful and informative comments
> that explain why we have to do all these horrible things :-).

I can't take credit for this; I'm just copying Dan's comment
from linux-nat.c.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]