This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Ping: [PATCH] testsuite: Add (extensive) hardware breakpoint testing
- From: Pedro Alves <palves at redhat dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org, Doug Evans <dje at google dot com>, Joel Brobecker <brobecker at adacore dot com>
- Date: Tue, 28 Feb 2012 17:12:56 +0000
- Subject: Re: Ping: [PATCH] testsuite: Add (extensive) hardware breakpoint testing
- References: <alpine.DEB.1.10.1111101340460.4191@tp.orcam.me.uk> <CADPb22Qe6G76gDRkVtXhzOhR0w+3VsC9=-eHt-aM=1w8+V7qPg@mail.gmail.com> <alpine.DEB.1.10.1111111907260.4191@tp.orcam.me.uk> <alpine.DEB.1.10.1112081529330.5354@tp.orcam.me.uk> <alpine.DEB.1.10.1202272056010.4811@tp.orcam.me.uk>
On 02/27/2012 09:04 PM, Maciej W. Rozycki wrote:
> Hi,
>
> Where are we with this proposal of mine:
>
> http://sourceware.org/ml/gdb-patches/2011-11/msg00316.html
>
> ? Here's another update to add changes corresponding to recent
> adjustments to break.exp and to accomodate the year roll-over:
I read the thread from the start, and I diffed the new proposed test against break.exp,
and I think we should go ahead and put this in. Only a couple remarks below.
> +# Copyright 2012 Free Software Foundation, Inc.
I think dropping the original copyright years was a mistake.
> +if { [prepare_for_testing hbreak2.exp "break" {break.c break1.c} {debug nowarnings}] } {
s/"break"/"hbreak2", so that running this test doesn't overwrite break.exp's binary.
More instances of this.
--
Pedro Alves