This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] MIPS/Linux: DSP ASE support


On 11/22/2011 04:14 PM, Maciej W. Rozycki wrote:

> 2011-11-22  Maciej W. Rozycki  <macro@mips.com>
>             Chris Dearman  <chris@mips.com>
>             Maciej W. Rozycki  <macro@codesourcery.com>
>             Joseph Myers  <joseph@codesourcery.com>
> 
> 	gdb/
> 	* features/mips-dsp.xml: New file.
> 	* features/mips64-dsp.xml: New file.
> 	* features/mips-dsp-linux.xml: New file.
> 	* features/mips64-dsp-linux.xml: New file.
> 	* features/Makefile (WHICH): Add mips-dsp-linux and
> 	mips64-dsp-linux.
> 	(mips-dsp-expedite, mips64-dsp-expedite): New variables.
> 	* features/mips-dsp-linux.c: New file.
> 	* features/mips64-dsp-linux.c: New file.
> 	* regformats/mips-dsp-linux.dat: New file.
> 	* regformats/mips64-dsp-linux.dat: New file.
> 	* mips-linux-nat.c (mips_linux_register_addr): Handle DSP
> 	registers.
> 	(mips64_linux_register_addr): Likewise.
> 	(mips64_linux_regsets_fetch_registers): Likewise.
> 	(mips64_linux_regsets_store_registers): Likewise.
>         (mips64_linux_fetch_registers): Update call to
>         mips64_linux_regsets_fetch_registers.
>         (mips64_linux_store_registers): Update call to
>         mips64_linux_regsets_store_registers.

Note tabs/spaces.

> 	(mips_linux_read_description): Probe for DSP registers.
> 	(_initialize_mips_linux_nat): Call initialize_tdesc_mips_dsp_linux
> 	and initialize_tdesc_mips64_dsp_linux.
> 	* mips-linux-tdep.c (supply_gregset, mips64_supply_gregset):
> 	Remove padding of no longer used embedded register slots.
> 	* mips-linux-tdep.h (DSP_BASE, DSP_CONTROL): New macros.
> 	(MIPS_RESTART_REGNUM): Redefine enum value.
> 	* mips-tdep.c (mips_generic_reg_names): Remove trailing null
> 	strings.
> 	(mips_tx39_reg_names): Likewise.
> 	(mips_linux_reg_names): New array of register names for Linux
> 	targets.
> 	(mips_register_name): Check for a null pointer in
> 	mips_processor_reg_names and return an empty string.
> 	(mips_register_type): Exclude embedded registers for the IRIX
> 	and Linux ABIs.
> 	(mips_pseudo_register_type): Likewise.  Use dynamic numbers to
> 	refer to FP registers, LO, HI, BadVAddr, Cause and PC.  Handle
> 	DSP registers.
> 	(mips_stab_reg_to_regnum): Handle DSP accumulators.
> 	(mips_dwarf_dwarf2_ecoff_reg_to_regnum): Likewise.
> 	(mips_gdbarch_init): Likewise.  Initialize internal register
> 	indices for the Linux ABI.  Use dynamic numbers to refer to
> 	registers, as applicable, while parsing the target description.
> 	* mips-tdep.h (struct mips_regnum): Add dspacc/dspctl offsets.
> 
> 2011-11-22  Maciej W. Rozycki  <macro@codesourcery.com>
> 
> 	gdb/gdbserver/
> 	* linux-low.h (linux_target_ops): Add regset_bitmap member.
> 	* linux-low.c (use_linux_regsets): New macro.
> 	(regsets_fetch_inferior_registers): Likewise.
> 	(regsets_store_inferior_registers): Likewise.

See <http://www.gnu.org/prep/standards/standards.html#Conditional-Changes>
for what the standard says about conditional changes.  In this case,
you'd write something like:

 	* linux-low.c (use_linux_regsets): New macro.
 	[!HAVE_LINUX_REGSETS] (regsets_fetch_inferior_registers): Likewise.
 	[!HAVE_LINUX_REGSETS] (regsets_store_inferior_registers): Likewise.

> 	(linux_register_in_regsets): New function.
> 	(usr_fetch_inferior_registers): Skip registers covered by
> 	regsets.
> 	(usr_store_inferior_registers): Likewise.
> 	(usr_fetch_inferior_registers): New macro.
> 	(usr_store_inferior_registers): Likewise.
> 	(linux_fetch_registers): Handle mixed regset/non-regset targets.
> 	(linux_store_registers): Likewise.


> 	* linux-mips-low.c (init_registers_mips_dsp_linux): New
> 	prototype.
> 	(init_registers_mips64_dsp_linux): Likewise.
> 	(init_registers_mips_linux): New macro.
> 	(init_registers_mips_dsp_linux): Likewise.
> 	(mips_dsp_num_regs): Likewise.
> 	(DSP_BASE, DSP_CONTROL): New fallback macros.
> 	(mips_base_regs): New macro.
> 	(mips_regmap): Use it.  Fix the size.
> 	(mips_dsp_regmap): New variable.
> 	(mips_dsp_regset_bitmap): Likewise.
> 	(mips_arch_setup): New function.
> 	(mips_cannot_fetch_register): Use the_low_target.regmap rather
> 	than mips_regmap.
> 	(mips_cannot_store_register): Likewise.
> 	(the_low_target): Update .arch_setup, .num_regs and .regmap
> 	initializers.  Add .regset_bitmap initializer.
> 	* linux-arm-low.c (the_low_target): Add .regset_bitmap
> 	initializer.
> 	* linux-bfin-low.c (the_low_target): Likewise.
> 	* linux-cris-low.c (the_low_target): Likewise.
> 	* linux-crisv32-low.c (the_low_target): Likewise.
> 	* linux-ia64-low.c (the_low_target): Likewise.
> 	* linux-m32r-low.c (the_low_target): Likewise.
> 	* linux-m68k-low.c (the_low_target): Likewise.
> 	* linux-ppc-low.c (the_low_target): Likewise.
> 	* linux-s390-low.c (the_low_target): Likewise.
> 	* linux-sh-low.c (the_low_target): Likewise.
> 	* linux-sparc-low.c (the_low_target): Likewise.
> 	* linux-tic6x-low.c (the_low_target): Likewise.
> 	* linux-x86-low.c (the_low_target): Likewise.
> 	* linux-xtensa-low.c (the_low_target): Likewise.
> 	* configure.srv <mips*-*-linux*>: Add mips-dsp-linux.o and
> 	mips64-dsp-linux.o to srv_regobj.  Add mips-dsp-linux.xml,
> 	mips64-dsp-linux.xml, mips-dsp.xml and mips64-dsp.xml to
> 	srv_xmlfiles.
> 	* Makefile.in (mips-dsp-linux.o, mips-dsp-linux.c): New targets.
> 	(mips64-dsp-linux.o, mips64-dsp-linux.c): Likewise.
> 
> 2011-11-22  Maciej W. Rozycki  <macro@mips.com>
> 
> 	gdb/testsuite/
> 	* gdb.xml/tdesc-regs.exp: Add "mips-dsp.xml" to the list of MIPS
> 	core registers.

Looks okay to me, but a change to the manual to document to new standard
xml feature (org.gnu.gdb.mips.dsp) is missing.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]