[RFC] Remove symbol-reloading option

[dje at google dot com (Doug Evans)]

Hi.
The symbol-reloading option is no longer used for anything.
IWBN to delete it, but we could first mark it as deprecated, or whatever.

2012-02-28  Doug Evans  <dje@google.com>

	* NEWS: Mention symbol-reloading has been deleted.
	* symfile.c (symbol_reloading): Delete.
	(show_symbol_reloading): Delete.
	(_initialize_symfile): Delete set/show symbol-reloading.

	doc/
	* gdb.texinfo (Help): Change apropos example to use "alias" instead
	of "reload".
	(Symbols): Delete docs for set/show symbol-reloading.
	* gdbint.texinfo (Defining Other Architecture Features): Delete
	SYMBOL_RELOADING_DEFAULT.
	* refcard.tex: Delete reference to symbol-reloading.

	testsuite/
	* gdb.base/default.exp: Delete tests for symbol-reloading.
	* gdb.base/help.exp: Ditto.
	* gdb.base/setshow.exp: Ditto.
	* gdb.base/gdb_history: Delete references to symbol-reloading.

Index: NEWS
===================================================================
RCS file: /cvs/src/src/gdb/NEWS,v
retrieving revision 1.490
diff -u -p -r1.490 NEWS
--- NEWS	24 Feb 2012 15:04:58 -0000	1.490
+++ NEWS	28 Feb 2012 21:32:49 -0000
@@ -3,6 +3,8 @@
 
 *** Changes since GDB 7.4
 
+* The option "symbol-reloading" has been deleted as it is no longer used.
+
 * Python scripting
 
   ** The "maint set python print-stack on|off" is now deleted.
Index: symfile.c
===================================================================
RCS file: /cvs/src/src/gdb/symfile.c,v
retrieving revision 1.328
diff -u -p -r1.328 symfile.c
--- symfile.c	21 Feb 2012 06:55:36 -0000	1.328
+++ symfile.c	28 Feb 2012 20:15:12 -0000
@@ -147,23 +147,6 @@ DEF_VEC_P (sym_fns_ptr);
 
 static VEC (sym_fns_ptr) *symtab_fns = NULL;
 
-/* Flag for whether user will be reloading symbols multiple times.
-   Defaults to ON for VxWorks, otherwise OFF.  */
-
-#ifdef SYMBOL_RELOADING_DEFAULT
-int symbol_reloading = SYMBOL_RELOADING_DEFAULT;
-#else
-int symbol_reloading = 0;
-#endif
-static void
-show_symbol_reloading (struct ui_file *file, int from_tty,
-		       struct cmd_list_element *c, const char *value)
-{
-  fprintf_filtered (file, _("Dynamic symbol table reloading "
-			    "multiple times in one run is %s.\n"),
-		    value);
-}
-
 /* If non-zero, shared library symbols will be added automatically
    when the inferior is created, new libraries are loaded, or when
    attaching to the inferior.  This is almost always what users will
@@ -3833,14 +3816,6 @@ for access from GDB.\n\
 A load OFFSET may also be given."), &cmdlist);
   set_cmd_completer (c, filename_completer);
 
-  add_setshow_boolean_cmd ("symbol-reloading", class_support,
-			   &symbol_reloading, _("\
-Set dynamic symbol table reloading multiple times in one run."), _("\
-Show dynamic symbol table reloading multiple times in one run."), NULL,
-			   NULL,
-			   show_symbol_reloading,
-			   &setlist, &showlist);
-
   add_prefix_cmd ("overlay", class_support, overlay_command,
 		  _("Commands for debugging overlays."), &overlaylist,
 		  "overlay ", 0, &cmdlist);
Index: doc/gdb.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
retrieving revision 1.926
diff -u -p -r1.926 gdb.texinfo
--- doc/gdb.texinfo	25 Feb 2012 13:54:25 -0000	1.926
+++ doc/gdb.texinfo	28 Feb 2012 20:15:13 -0000
@@ -1699,7 +1699,7 @@ commands, and their documentation, for t
 @var{args}.  It prints out all matches found.  For example:
 
 @smallexample
-apropos reload
+apropos alias
 @end smallexample
 
 @noindent
@@ -1707,10 +1707,11 @@ results in:
 
 @smallexample
 @c @group
-set symbol-reloading -- Set dynamic symbol table reloading
-                        multiple times in one run
-show symbol-reloading -- Show dynamic symbol table reloading
-                        multiple times in one run
+alias -- Define a new command that is an alias of an existing command
+aliases -- Aliases of other commands
+d -- Delete some breakpoints or auto-display expressions
+del -- Delete some breakpoints or auto-display expressions
+delete -- Delete some breakpoints or auto-display expressions
 @c @end group
 @end smallexample
 
@@ -14720,33 +14721,6 @@ from the @code{ptype} command can be ove
 which match the regular-expression @var{regexp}.
 @end ignore
 
-@cindex reloading symbols
-Some systems allow individual object files that make up your program to
-be replaced without stopping and restarting your program.  For example,
-in VxWorks you can simply recompile a defective object file and keep on
-running.  If you are running on one of these systems, you can allow
-@value{GDBN} to reload the symbols for automatically relinked modules:
-
-@table @code
-@kindex set symbol-reloading
-@item set symbol-reloading on
-Replace symbol definitions for the corresponding source file when an
-object file with a particular name is seen again.
-
-@item set symbol-reloading off
-Do not replace symbol definitions when encountering object files of the
-same name more than once.  This is the default state; if you are not
-running on a system that permits automatic relinking of modules, you
-should leave @code{symbol-reloading} off, since otherwise @value{GDBN}
-may discard symbols when linking large programs, that may contain
-several modules (from different directories or libraries) with the same
-name.
-
-@kindex show symbol-reloading
-@item show symbol-reloading
-Show the current @code{on} or @code{off} setting.
-@end table
-
 @cindex opaque data types
 @kindex set opaque-type-resolution
 @item set opaque-type-resolution on
Index: doc/gdbint.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdbint.texinfo,v
retrieving revision 1.335
diff -u -p -r1.335 gdbint.texinfo
--- doc/gdbint.texinfo	13 Jan 2012 14:31:55 -0000	1.335
+++ doc/gdbint.texinfo	28 Feb 2012 20:15:13 -0000
@@ -4916,11 +4916,6 @@ number of that register.
 Use this function to convert stab register @var{stab_regnr} into @value{GDBN}
 regnum.  If not defined, no conversion will be done.
 
-@item SYMBOL_RELOADING_DEFAULT
-@findex SYMBOL_RELOADING_DEFAULT
-The default value of the ``symbol-reloading'' variable.  (Never defined in
-current sources.)
-
 @item TARGET_CHAR_BIT
 @findex TARGET_CHAR_BIT
 Number of bits in a char; defaults to 8.
Index: doc/refcard.tex
===================================================================
RCS file: /cvs/src/src/gdb/doc/refcard.tex,v
retrieving revision 1.10
diff -u -p -r1.10 refcard.tex
--- doc/refcard.tex	4 Jan 2012 08:17:21 -0000	1.10
+++ doc/refcard.tex	28 Feb 2012 20:15:13 -0000
@@ -68,7 +68,7 @@
 % all variations of a command.
 % The GDB-under-Emacs section omits gdb-mode functions without default
 % keybindings.  GDB startup options are not described.
-% set print sevenbit-strings, set symbol-reloading omitted.
+% set print sevenbit-strings omitted.
 % printsyms, printpsyms, omitted since they're for GDB maintenance primarily
 % share omitted due to obsolescence
 % set check range/type omitted at least til code is in GDB.
Index: testsuite/gdb.base/default.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/default.exp,v
retrieving revision 1.56
diff -u -p -r1.56 default.exp
--- testsuite/gdb.base/default.exp	13 Feb 2012 18:09:59 -0000	1.56
+++ testsuite/gdb.base/default.exp	28 Feb 2012 20:15:13 -0000
@@ -560,8 +560,6 @@ gdb_test_no_output "set print vtbl" "set
 # FIXME -- need a test for "set prompt"
 #test set radix
 gdb_test "set radix" "Input and output radices now set to decimal 10, hex a, octal 12.*" "set radix"
-#test set symbol-reloading
-gdb_test_no_output "set symbol-reloading" "set symbol-reloading"
 #test set variable
 gdb_test "set variable" "Argument required .expression to compute.*" "set variable"
 #test set verbose
@@ -663,8 +661,6 @@ gdb_test "show print vtbl" "Printing of 
 gdb_test "show prompt" "Gdb's prompt is \"$gdb_prompt \".*" "show prompt"
 #test show radix
 gdb_test "show radix" "Input and output radices set to decimal 10, hex a, octal 12." "show radix"
-#test show symbol-reloading
-gdb_test "show symbol-reloading" "Dynamic symbol table reloading multiple times in one run is on." "show symbol-reloading"
 #test show user
 gdb_test_no_output "show user" "show user"
 #test show values
Index: testsuite/gdb.base/gdb_history
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/gdb_history,v
retrieving revision 1.2
diff -u -p -r1.2 gdb_history
--- testsuite/gdb.base/gdb_history	24 Jan 2012 15:13:30 -0000	1.2
+++ testsuite/gdb.base/gdb_history	28 Feb 2012 20:15:13 -0000
@@ -176,7 +176,6 @@ set print sevenbit-strings
 set print union
 set print vtbl
 set radix
-set symbol-reloading
 set variable
 set verbose
 set width
@@ -220,7 +219,6 @@ show print union
 show print vtbl
 show prompt
 show radix
-show symbol-reloading
 show user
 show values
 show verbose
Index: testsuite/gdb.base/help.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/help.exp,v
retrieving revision 1.55
diff -u -p -r1.55 help.exp
--- testsuite/gdb.base/help.exp	24 Jan 2012 15:13:30 -0000	1.55
+++ testsuite/gdb.base/help.exp	28 Feb 2012 20:15:13 -0000
@@ -458,8 +458,6 @@ gdb_test "help set print vtbl" "Set prin
 gdb_test "help set prompt" "Set gdb's prompt" "help set prompt"
 # test help set radix
 gdb_test "help set radix" "Set default input and output number radices\.\[\r\n\]+Use \'set input-radix\' or \'set output-radix\' to independently set each\.\[\r\n\]+Without an argument, sets both radices back to the default value of 10\." "help set radix"
-# test help set symbol-reloading
-gdb_test "help set symbol-reloading" "Set dynamic symbol table reloading multiple times in one run\." "help set symbol-reloading"
 # test help set variable
 gdb_test "help set variable" "Evaluate expression EXP and assign result to variable VAR, using assignment\[\r\n\]+syntax appropriate for the current language \\(VAR = EXP or VAR := EXP for\[\r\n\]+example\\)\.  VAR may be a debugger \"convenience\" variable \\(names starting\[\r\n\]+with \\\$\\), a register \\(a few standard names starting with \\\$\\), or an actual\[\r\n\]+variable in the program being debugged\.  EXP is any valid expression\.\[\r\n\]+This may usually be abbreviated to simply \"set\"\." "help set variable"
 # test help set verbose
@@ -571,8 +569,6 @@ gdb_test "help show print vtbl" "Show pr
 gdb_test "help show prompt" "Show gdb's prompt" "help show prompt"
 # test help show radix
 gdb_test "help show radix" "Show the default input and output number radices\.\[\r\n\]+Use \'show input-radix\' or \'show output-radix\' to independently show each\." "help show radix"
-# test help show symbol-reloading
-gdb_test "help show symbol-reloading" "Show dynamic symbol table reloading multiple times in one run\." "help show symbol-reloading"
 # test help show user
 gdb_test "help show user" "Show definitions of user defined commands\.\[\r\n\]+Argument is the name of the user defined command\.\[\r\n\]+With no argument, show definitions of all user defined commands\." "help show user"
 # test help show values
Index: testsuite/gdb.base/setshow.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/setshow.exp,v
retrieving revision 1.24
diff -u -p -r1.24 setshow.exp
--- testsuite/gdb.base/setshow.exp	16 Jan 2012 16:21:45 -0000	1.24
+++ testsuite/gdb.base/setshow.exp	28 Feb 2012 20:15:13 -0000
@@ -242,10 +242,6 @@ gdb_test_no_output "set write on" "set w
 #test show write on
 # This is only supported on targets which use exec.o.
 gdb_test "show write" "Writing into executable and core files is on..*" "show write (on)" 
-#test set symbol-reloading on
-gdb_test_no_output "set symbol-reloading on" "set symbol-reloading on" 
-#test show symbol-reloading on
-gdb_test "show symbol-reloading" "Dynamic symbol table reloading multiple times in one run is on..*" "show symbol-reloading (on)" 
 #test show user
 gdb_test_no_output "show user" "show user" 
 #test set verbose on