This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch/testsuite/gdbserver] unsuspend lwps after step over
- From: Pedro Alves <palves at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Thu, 01 Mar 2012 11:24:41 +0000
- Subject: Re: [patch/testsuite/gdbserver] unsuspend lwps after step over
- References: <4F3DBB7F.6060501@codesourcery.com> <4F4CFE8E.7040906@redhat.com> <4F4DA6C1.9060500@codesourcery.com> <4F4DFDC7.6060805@redhat.com>
On 02/29/2012 10:28 AM, Pedro Alves wrote:
> Thanks. This is okay, with one nit.
>
> On 02/29/2012 04:17 AM, Yao Qi wrote:
>> +if { [gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile \
>> + executable [list debug $additional_flags] ] != "" } {
>> + untested itset.exp
>
> Not itset.exp :-).
>
> I never really understood why we tend to put the test name in untested
> calls; we end just up with the test name duplicated:
>
> UNTESTED: gdb.threads/current-lwp-dead.exp: current-lwp-dead.exp
> UNTESTED: gdb.threads/gcore-thread.exp: gcore-thread.exp
>
> I'd rather we spelled out the _reason_ why the test was untested.
> So I suggest instead something like:
>
> untested "Couldn't compile test program"
>
> Unfortunately, we do have a _lot_ of instances to fix:
>
> $ grep -rn "untested.*\.exp" * | wc -l
> 509
>
> But I think we should stop adding more.
I went ahead and added this to the testcase cookbook
at <http://sourceware.org/gdb/wiki/GDBTestcaseCookbook>.
--
Pedro Alves