This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 1/2] Linespec rewrite (update 2)


On 04/05/2012 08:54 AM, Doug Evans wrote:
On Thu, Apr 5, 2012 at 8:21 AM, Tom Tromey<tromey@redhat.com> wrote:
"Keith" == Keith Seitz<keiths@redhat.com> writes:

Keith> Given Doug's comments earlier today, I'm reposting anything that Keith> hasn't already been approved or which changed. The easiest way to see Keith> what's happened is, of course, by inspecting the commit history of the Keith> branch.

Keith> I'll follow-up separately with the other patch that was updated.

I have no further comments. I think it looks great.

I think at this point you just need Doug's ok.

All I had were nits, so 'tis ok with me.

And with that, I've committed the lot.


Thank you to everyone who reviewed and played with the patchset!

Keith


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]