Re: [patch] Fix in-src-tree builds by gdbserver/gnulib/ copy [Re: [PATCH] Link gnulib in gdbserver.]

[Yao Qi <yao at codesourcery dot com>]

On 04/16/2012 12:49 AM, Jan Kratochvil wrote:
> On Sat, 14 Apr 2012 05:39:52 +0200, Yao Qi wrote:
>> On 04/14/2012 05:25 AM, Jan Kratochvil wrote:
>     This broke in-src-tree build:
> [...]
>>> gcc: error: gnulib/libgnu.a: No such file or directory
>>> make[4]: *** [gdbserver] Error 1
>>> make[4]: Leaving directory `/home/jkratoch/redhat/gdb-clean/gdb/gdbserver'
>>
>> It is wired.  I don't see such failure in in-source-tree (CVS trunk) build.
> 
> I do, on {x86_64,i686}-fedora{15,16,17,rawhide}-linux-gnu, not sure why it is
> not reproducible for you - I also see it logical why it fails - using VPATH
> make finds gnulib/libgnu.a in the gnulib source directory (gdb/gnulib/) and
> therefore it does not rebuild libgnu.a in gdbserver/gnulib/ .
> 

Because I did an "in-gdbserver-source-tree" build.  I can reproduce this
failure now in a "in-gdb-source-tree" build.

> 
> AFAIK the GNU tools do not provide good enough support for the exact problem
> here, therefore for building in-source-tree and having another build directory
> of the source directory already containing pre-build binaries.
> 
> Therefore proposing to:
>  * Have single copy gdb/gnulib/ in CVS repository.
>  * Have two copies in the .tar distribution, it does not cost much:
>    225280 uncompressed
>     40970 gzip
>     32676 xz
>  * For direct build from repository in-source-tree do a clean binaries-less
>    copy from gdb/gnulib/ into gdbserver/gnulib/ .
>  * For direct build from repository out-of-source-tree do a clean binaries-less
>    copy from srcdir-gdb/gnulib/ into objdir-gdbserver/gnulib/ patching there
>    @*srcdir*@ variables so that it does not try
>    to access srcdir-gdbserver/gnulib/ which does not exist and where we must
>    not write anything.

I am afraid your patch doesn't work for gdbserver-only build, because
target `diststuff' is not invoked at all.  I tried to fix it, but
finally I give up, because I have to differentiate gdb+gdbserver build
and gdbserver-only build when setting some dirs.

-- 
Yao (éå)