This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: bfd_section should not be NULL in call to prim_record_minimal_*


> This change is fine with me -- even more than fine, I think removing
> special cases is generally better when possible.

Thanks. I will commit this change today.

> However, if this is just a regression caused by linespec changes, maybe
> it can also be fixed in another way.  That is, you can find a minsym's
> objfile using msymbol_objfile; I think this would fix the possibly
> problematic uses I see in linespec.c (the one in minsym_found is maybe
> ok).

Yes, I agree. I read the entire thread, and it seems so simple to
fix the problem that way as well.  I think both approaches should
be applied.

> Did you audit the other symbol readers?

Hmmm, no. Wildo.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]