This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix in-src-tree builds by making gdbserver/gnulib/ a separate library (a la libiberty, etc.), and adding ACX_CONFIGURE_DIR.


On 04/16/2012 06:43 PM, Jan Kratochvil wrote:

> On Mon, 16 Apr 2012 19:32:04 +0200, Pedro Alves wrote:
>> Follows the patch.  What do you all think?
> 
> I agree in general.  I would rename gnulib/gnulib/ to some unique names
> instead, it is a mess.


I tried to come up with something, but it isn't easy (to me).

I thought of:

 gnulib/src/
 gnulib/import/

but that ends up with the confusing:

 GNULIB_CFLAGS=-I$(srcdir)/gnulib/src -I$(GNULIB_BUILDDIR)/src

Confusing because $(GNULIB_BUILDDIR)/src isn't really src, but the
built libgnu.a and the generated headers.

I thought of calling the wrapper dir libgnu, so:

 libgnu/gnulib/

which yields:

 GNULIB_CFLAGS=-I$(srcdir)/libgnu/gnulib -I$(GNULIB_BUILDDIR)/gnulib

or perhaps:

 LIBGNU_CFLAGS=-I$(srcdir)/libgnu/gnulib -I$(LIBGNU_BUILDDIR)/gnulib


Or another option:

 gnulib-wrapper/gnulib/

which looks ugly to me.

So, so far, I'm torn between:

 libgnu/gnulib/
 gnulib/gnulib/

Any other options?  Preferences?

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]