This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC - Python scripting] New methods Symtab.global_block and Symtab.static_block (docs included)


> Date: Tue, 17 Apr 2012 12:55:43 +0530
> From: Siva Chandra <sivachandra@google.com>
> 
> +  ** New methods 'global_block' and 'static_block' on gdb.Symtab objects
> +     which return the global and static blocks (as gdb.Block objects),
> +     of the underlying symbol table, respectively.

This is OK.

> +@defun Symtab.global_block ()
> +Return the global block of the underlying symbol table.  Note that,
> +though highly unlikely, the returned @code{gdb.Block} objects are not
> +guaranteed to be identical across different @value{GDBN} releases.
> +@end defun
> +
> +@defun Symtab.static_block ()
> +Return the static block of the underlying symbol table.  Note that,
> +though highly unlikely, the returned @code{gdb.Block} objects are not
> +guaranteed to be identical across different @value{GDBN} releases.
> +@end defun

I think it would be a good idea to have here a cross-reference to
"Blocks in Python".

Also, the 2 identical sentences about the objects not being preserved
across GDB releases should probably be replaced by just one sentence,
saying this for both types of blocks.

The documentation parts are OK with those changes.

Thanks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]