This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC - Python scripting] New methods Symtab.global_block and Symtab.static_block (docs included)
- From: Tom Tromey <tromey at redhat dot com>
- To: Siva Chandra <sivachandra at google dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 17 Apr 2012 11:33:37 -0600
- Subject: Re: [RFC - Python scripting] New methods Symtab.global_block and Symtab.static_block (docs included)
- References: <CAGyQ6gyuJ1oYBH3O5gzNc7Y7NK7AGC2F9a8Z3ts4dMm0GpVy0g@mail.gmail.com>
>>>>> "Siva" == Siva Chandra <sivachandra@google.com> writes:
Siva> The attached patch is a result of discussions here:
Siva> http://sourceware.org/ml/gdb-patches/2012-04/msg00226.html
Siva> and here:
Siva> http://sourceware.org/ml/gdb-patches/2012-04/msg00302.html
Thanks.
It looks pretty good, just a little nit.
Siva> + block = symtab->blockvector->block[GLOBAL_BLOCK];
Siva> + block = symtab->blockvector->block[STATIC_BLOCK];
These two spots should use the BLOCKVECTOR accessor macro.
Ok with that change.
Tom