This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] Remove board setting `gdb,cannot_call_functions'
- From: Yao Qi <yao at codesourcery dot com>
- To: <gdb-patches at sourceware dot org>
- Date: Mon, 23 Apr 2012 18:34:14 +0800
- Subject: [PATCH] Remove board setting `gdb,cannot_call_functions'
Hi,
When documenting all exiting board settings we are using,
`gdb,cannot_call_functions' is interesting to me. What does
`gdb,cannot_call_functions' mean? Can't do inf-call?
CVS log shows that they were introduced when they were imported to CVS
repository. Do we still use this setting? or remove it completely.
I can't imagine that a port can't do function calls. In history,
A29K port can't do function calls, but this port has been removed
from GDB.
Some parts of patch shows that this setting is related
to 2416, but PR 2416 is not related to this at all,
Bug 2416 - autogen.sh, should take relative or absolute path, and configure
http://sourceware.org/bugzilla/show_bug.cgi?id=2416
It is quite impossible that someone is still setting
`gdb,cannot_call_functions' in his/her board file, I assume. However,
I might be wrong.
gdb/testsuite:
2012-04-23 Yao Qi <yao@codesourcery.com>
* gdb.base/call-ar-st.exp: Don't check board setting
`gdb,cannot_call_functions' any more.
* gdb.base/call-rt-st.exp, gdb.base/call-sc.exp: Likewise.
* gdb.base/call-signal-resume.exp, gdb.base/call-strs.exp:
* gdb.base/callexit.exp, gdb.base/callfuncs.exp: Likewise.
* gdb.base/nodebug.exp, gdb.base/printcmds.exp: Likewise.
* gdb.base/ptype.exp, gdb.base/structs.exp: Likewise.
* gdb.base/unwindonsignal.exp, gdb.base/watchpoint.exp: Likewise.
* gdb.cp/gdb2495.exp, gdb.cp/templates.exp: Likewise.
* gdb.cp/virtfunc.exp, gdb.hp/gdb.base-hp/callfwmall.exp: Likewise.
* gdb.threads/hand-call-in-threads.exp: Likewise.
* gdb.threads/interrupted-hand-call.exp: Likewise.
* gdb.threads/thread-unwindonsignal.exp: Likewise.
---
gdb/testsuite/gdb.base/call-ar-st.exp | 8 ---
gdb/testsuite/gdb.base/call-rt-st.exp | 8 ---
gdb/testsuite/gdb.base/call-sc.exp | 10 ----
gdb/testsuite/gdb.base/call-signal-resume.exp | 8 ---
gdb/testsuite/gdb.base/call-strs.exp | 11 -----
gdb/testsuite/gdb.base/callexit.exp | 8 ---
gdb/testsuite/gdb.base/callfuncs.exp | 8 ---
gdb/testsuite/gdb.base/nodebug.exp | 48 +++++++++-----------
gdb/testsuite/gdb.base/printcmds.exp | 13 -----
gdb/testsuite/gdb.base/ptype.exp | 6 ---
gdb/testsuite/gdb.base/structs.exp | 10 ----
gdb/testsuite/gdb.base/unwindonsignal.exp | 8 ---
gdb/testsuite/gdb.base/watchpoint.exp | 4 +-
gdb/testsuite/gdb.cp/gdb2495.exp | 8 ---
gdb/testsuite/gdb.cp/templates.exp | 6 ---
gdb/testsuite/gdb.cp/virtfunc.exp | 6 ---
gdb/testsuite/gdb.hp/gdb.base-hp/callfwmall.exp | 9 ----
gdb/testsuite/gdb.threads/hand-call-in-threads.exp | 8 ---
.../gdb.threads/interrupted-hand-call.exp | 8 ---
.../gdb.threads/thread-unwindonsignal.exp | 8 ---
20 files changed, 23 insertions(+), 180 deletions(-)
diff --git a/gdb/testsuite/gdb.base/call-ar-st.exp b/gdb/testsuite/gdb.base/call-ar-st.exp
index 50ca37c..09da100 100644
--- a/gdb/testsuite/gdb.base/call-ar-st.exp
+++ b/gdb/testsuite/gdb.base/call-ar-st.exp
@@ -39,14 +39,6 @@ if [get_compiler_info ${binfile}] {
return -1;
}
-# Some targets can't call functions, so don't even bother with this
-# test.
-if [target_info exists gdb,cannot_call_functions] {
- setup_xfail "*-*-*" 2416
- fail "This target can not call functions"
- continue
-}
-
set oldtimeout $timeout
set timeout [expr "$timeout + 60"]
diff --git a/gdb/testsuite/gdb.base/call-rt-st.exp b/gdb/testsuite/gdb.base/call-rt-st.exp
index a531188..16b5b49 100644
--- a/gdb/testsuite/gdb.base/call-rt-st.exp
+++ b/gdb/testsuite/gdb.base/call-rt-st.exp
@@ -45,14 +45,6 @@ if [get_compiler_info ${binfile}] {
return -1;
}
-# Some targets can't do function calls, so don't even bother with this
-# test.
-if [target_info exists gdb,cannot_call_functions] {
- setup_xfail "*-*-*" 2416
- fail "This target can not call functions"
- continue
-}
-
# Start with a fresh gdb.
gdb_exit
diff --git a/gdb/testsuite/gdb.base/call-sc.exp b/gdb/testsuite/gdb.base/call-sc.exp
index 135010c..1c2d7ef 100644
--- a/gdb/testsuite/gdb.base/call-sc.exp
+++ b/gdb/testsuite/gdb.base/call-sc.exp
@@ -18,16 +18,6 @@
# Test "return", "finish", and "call" of functions that a scalar (int,
# float, enum) and/or take a single scalar parameter.
-
-# Some targets can't call functions, so don't even bother with this
-# test.
-
-if [target_info exists gdb,cannot_call_functions] {
- setup_xfail "*-*-*"
- fail "This target can not call functions"
- continue
-}
-
set testfile "call-sc"
set srcfile ${testfile}.c
set binfile ${objdir}/${subdir}/${testfile}
diff --git a/gdb/testsuite/gdb.base/call-signal-resume.exp b/gdb/testsuite/gdb.base/call-signal-resume.exp
index d383f5c..1c89805 100644
--- a/gdb/testsuite/gdb.base/call-signal-resume.exp
+++ b/gdb/testsuite/gdb.base/call-signal-resume.exp
@@ -40,14 +40,6 @@ if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {deb
return -1
}
-# Some targets can't do function calls, so don't even bother with this
-# test.
-if [target_info exists gdb,cannot_call_functions] {
- setup_xfail "*-*-*" 2416
- fail "This target can not call functions"
- continue
-}
-
proc get_dummy_frame_number { } {
global gdb_prompt
diff --git a/gdb/testsuite/gdb.base/call-strs.exp b/gdb/testsuite/gdb.base/call-strs.exp
index 43d7ef6..41371e2 100644
--- a/gdb/testsuite/gdb.base/call-strs.exp
+++ b/gdb/testsuite/gdb.base/call-strs.exp
@@ -37,17 +37,6 @@ if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {deb
return -1
}
-
-
-# Some targets can't call functions, so don't even bother with this
-# test.
-if [target_info exists gdb,cannot_call_functions] {
- setup_xfail "*-*-*" 2416
- fail "This target can not call functions"
- continue
-}
-
-
# Start with a fresh gdb.
gdb_exit
diff --git a/gdb/testsuite/gdb.base/callexit.exp b/gdb/testsuite/gdb.base/callexit.exp
index c4d1ec5..bba2f10 100644
--- a/gdb/testsuite/gdb.base/callexit.exp
+++ b/gdb/testsuite/gdb.base/callexit.exp
@@ -23,14 +23,6 @@ if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {deb
return -1
}
-# Some targets can't do function calls, so don't even bother with this
-# test.
-if [target_info exists gdb,cannot_call_functions] {
- setup_xfail "*-*-*" 2416
- fail "This target can not call functions"
- continue
-}
-
# Start with a fresh gdb.
gdb_exit
diff --git a/gdb/testsuite/gdb.base/callfuncs.exp b/gdb/testsuite/gdb.base/callfuncs.exp
index c48fa60..6b84894 100644
--- a/gdb/testsuite/gdb.base/callfuncs.exp
+++ b/gdb/testsuite/gdb.base/callfuncs.exp
@@ -43,14 +43,6 @@ if {$hp_aCC_compiler} {
set prototypes 0
}
-# Some targets can't do function calls, so don't even bother with this
-# test.
-if [target_info exists gdb,cannot_call_functions] {
- setup_xfail "*-*-*" 2416
- fail "This target can not call functions"
- continue
-}
-
# FIXME: Before calling this proc, we should probably verify that
# we can call inferior functions and get a valid integral value
# returned.
diff --git a/gdb/testsuite/gdb.base/nodebug.exp b/gdb/testsuite/gdb.base/nodebug.exp
index 344a804..b8424f2 100644
--- a/gdb/testsuite/gdb.base/nodebug.exp
+++ b/gdb/testsuite/gdb.base/nodebug.exp
@@ -176,36 +176,32 @@ if [runto inner] then {
if { ! [test_compiler_info "gcc-*"]} {
setup_xfail "mips-sgi-irix6*"
}
- if [target_info exists gdb,cannot_call_functions] {
- setup_xfail "*-*-*" 2416
- fail "p/c array_index(\"abcdef\",2)"
- } else {
- #
- # On HP-UX, a support function (__d_plt_call) necessary to
- # implement an inferior call is normally only available when
- # the inferior was compiled with -g. Thus, we expect this
- # testpoint to fail on HP-UX.
- if { [istarget "hppa*-hpux*"] } {
- gdb_test_multiple "p/c array_index(\"abcdef\",2)" \
- "p/c array_index(\"abcdef\",2)" {
- -re ".*Suggest linking executable with -g.*$gdb_prompt $" {
- pass "p/c array_index(\"abcdef\",2)"
- }
- -re ".*Cannot find __wdb_call_dummy in.*end.o.*" {
- pass "p/c array_index(\"abcdef\",2)"
- }
+
+ #
+ # On HP-UX, a support function (__d_plt_call) necessary to
+ # implement an inferior call is normally only available when
+ # the inferior was compiled with -g. Thus, we expect this
+ # testpoint to fail on HP-UX.
+ if { [istarget "hppa*-hpux*"] } {
+ gdb_test_multiple "p/c array_index(\"abcdef\",2)" \
+ "p/c array_index(\"abcdef\",2)" {
+ -re ".*Suggest linking executable with -g.*$gdb_prompt $" {
+ pass "p/c array_index(\"abcdef\",2)"
+ }
+ -re ".*Cannot find __wdb_call_dummy in.*end.o.*" {
+ pass "p/c array_index(\"abcdef\",2)"
+ }
-re ".*99 'c'.*" {
pass "p/c array_index(\"abcdef\",2)"
}
}
- } else {
- # We need to up this because this can be really slow on some boards.
- # (malloc() is called as part of the test).
- set prev_timeout $timeout
- set timeout 60
- gdb_test {p/c array_index("abcdef",2)} " = 99 'c'"
- set timeout $prev_timeout
- }
+ } else {
+ # We need to up this because this can be really slow on some boards.
+ # (malloc() is called as part of the test).
+ set prev_timeout $timeout
+ set timeout 60
+ gdb_test {p/c array_index("abcdef",2)} " = 99 'c'"
+ set timeout $prev_timeout
}
# Now, try that we can give names of file-local symbols which happen
diff --git a/gdb/testsuite/gdb.base/printcmds.exp b/gdb/testsuite/gdb.base/printcmds.exp
index 08a54b0..47bc002 100644
--- a/gdb/testsuite/gdb.base/printcmds.exp
+++ b/gdb/testsuite/gdb.base/printcmds.exp
@@ -652,12 +652,6 @@ proc test_print_string_constants {} {
gdb_test_no_output "set print elements 50"
- if [target_info exists gdb,cannot_call_functions] {
- setup_xfail "*-*-*" 2416
- fail "This target can not call functions"
- return
- }
-
# We need to up this because this can be really slow on some boards.
# (Test may involve inferior malloc() calls).
set timeout 60;
@@ -675,13 +669,6 @@ proc test_print_string_constants {} {
}
proc test_print_array_constants {} {
-
- if [target_info exists gdb,cannot_call_functions] {
- setup_xfail "*-*-*" 2416
- fail "This target can not call functions"
- return
- }
-
# We need to up this because this can be really slow on some boards.
# (Test may involve inferior malloc() calls).
set timeout 60;
diff --git a/gdb/testsuite/gdb.base/ptype.exp b/gdb/testsuite/gdb.base/ptype.exp
index 51a3014..2929f55 100644
--- a/gdb/testsuite/gdb.base/ptype.exp
+++ b/gdb/testsuite/gdb.base/ptype.exp
@@ -618,12 +618,6 @@ gdb_test "ptype foo" "type = char" "ptype foo typedef after second list of charf
if [runto_main] then {
- if [target_info exists gdb,cannot_call_functions] {
- setup_xfail "*-*-*" 2416
- fail "This target can not call functions"
- continue
- }
-
# We need to up this because this can be really slow on some boards.
# (malloc() is called as part of the test).
set prev_timeout $timeout
diff --git a/gdb/testsuite/gdb.base/structs.exp b/gdb/testsuite/gdb.base/structs.exp
index e68ab6c..25d94a8 100644
--- a/gdb/testsuite/gdb.base/structs.exp
+++ b/gdb/testsuite/gdb.base/structs.exp
@@ -16,16 +16,6 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-
-# Some targets can't call functions, so don't even bother with this
-# test.
-
-if [target_info exists gdb,cannot_call_functions] {
- setup_xfail "*-*-*"
- fail "This target can not call functions"
- continue
-}
-
set testfile "structs"
set srcfile ${testfile}.c
set binfile ${objdir}/${subdir}/${testfile}
diff --git a/gdb/testsuite/gdb.base/unwindonsignal.exp b/gdb/testsuite/gdb.base/unwindonsignal.exp
index 3e22679..e0f5136 100644
--- a/gdb/testsuite/gdb.base/unwindonsignal.exp
+++ b/gdb/testsuite/gdb.base/unwindonsignal.exp
@@ -33,14 +33,6 @@ if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {deb
return -1
}
-# Some targets can't do function calls, so don't even bother with this
-# test.
-if [target_info exists gdb,cannot_call_functions] {
- setup_xfail "*-*-*" 2416
- fail "This target can not call functions"
- continue
-}
-
# Start with a fresh gdb.
gdb_exit
diff --git a/gdb/testsuite/gdb.base/watchpoint.exp b/gdb/testsuite/gdb.base/watchpoint.exp
index 15482fa..c0eaac3 100644
--- a/gdb/testsuite/gdb.base/watchpoint.exp
+++ b/gdb/testsuite/gdb.base/watchpoint.exp
@@ -851,9 +851,7 @@ proc do_tests {} {
test_disabling_watchpoints
- if ![target_info exists gdb,cannot_call_functions] {
- test_stepping
- }
+ test_stepping
}
# Tests below don't rely on the markers and watchpoint set by
diff --git a/gdb/testsuite/gdb.cp/gdb2495.exp b/gdb/testsuite/gdb.cp/gdb2495.exp
index 1f76ffa..2e28be9 100644
--- a/gdb/testsuite/gdb.cp/gdb2495.exp
+++ b/gdb/testsuite/gdb.cp/gdb2495.exp
@@ -58,14 +58,6 @@ if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debu
return -1
}
-# Some targets can't do function calls, so don't even bother with this
-# test.
-if [target_info exists gdb,cannot_call_functions] {
- setup_xfail "*-*-*" 2416
- fail "This target can not call functions"
- continue
-}
-
gdb_exit
gdb_start
gdb_reinitialize_dir $srcdir/$subdir
diff --git a/gdb/testsuite/gdb.cp/templates.exp b/gdb/testsuite/gdb.cp/templates.exp
index 72b65ae..69bcd56 100644
--- a/gdb/testsuite/gdb.cp/templates.exp
+++ b/gdb/testsuite/gdb.cp/templates.exp
@@ -176,12 +176,6 @@ proc test_template_calls {} {
global gdb_prompt
global hp_aCC_compiler
- if [target_info exists gdb,cannot_call_functions] {
- setup_xfail "*-*-*" 2416
- fail "This target can not call functions"
- return
- }
-
if {!$hp_aCC_compiler} {setup_xfail hppa*-*-*}
gdb_test_multiple "print t5i.value()" "print t5i.value()" {
-re ".* = 2\[\r\n\]*$gdb_prompt $" {
diff --git a/gdb/testsuite/gdb.cp/virtfunc.exp b/gdb/testsuite/gdb.cp/virtfunc.exp
index 15a374c..90e40fb 100644
--- a/gdb/testsuite/gdb.cp/virtfunc.exp
+++ b/gdb/testsuite/gdb.cp/virtfunc.exp
@@ -180,12 +180,6 @@ proc test_virtual_calls {} {
global gdb_prompt
global nl
- if [target_info exists gdb,cannot_call_functions] {
- setup_xfail "*-*-*" 2416
- fail "This target can not call functions"
- return 0
- }
-
gdb_test "print pAe->f()" "\\$\[0-9\]+ = 20"
gdb_test "print pAa->f()" "\\$\[0-9\]+ = 1"
gdb_test "print pDe->vg()" "\\$\[0-9\]+ = 202"
diff --git a/gdb/testsuite/gdb.hp/gdb.base-hp/callfwmall.exp b/gdb/testsuite/gdb.hp/gdb.base-hp/callfwmall.exp
index a9011ea..63cf228 100644
--- a/gdb/testsuite/gdb.hp/gdb.base-hp/callfwmall.exp
+++ b/gdb/testsuite/gdb.hp/gdb.base-hp/callfwmall.exp
@@ -106,15 +106,6 @@ if {$hp_aCC_compiler} {
set prototypes 0
}
-
-# Some targets can't call functions, so don't even bother with this
-# test.
-if [target_info exists gdb,cannot_call_functions] {
- setup_xfail "*-*-*" 2416
- fail "This target can not call functions"
- continue
-}
-
# Set the current language to C. This counts as a test. If it
# fails, then we skip the other tests.
diff --git a/gdb/testsuite/gdb.threads/hand-call-in-threads.exp b/gdb/testsuite/gdb.threads/hand-call-in-threads.exp
index ba0e74b..b1761b4 100644
--- a/gdb/testsuite/gdb.threads/hand-call-in-threads.exp
+++ b/gdb/testsuite/gdb.threads/hand-call-in-threads.exp
@@ -26,14 +26,6 @@ if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executab
return -1
}
-# Some targets can't do function calls, so don't even bother with this
-# test.
-if [target_info exists gdb,cannot_call_functions] {
- setup_xfail "*-*-*" 2416
- fail "This target can not call functions"
- continue
-}
-
proc get_dummy_frame_number { } {
global gdb_prompt
diff --git a/gdb/testsuite/gdb.threads/interrupted-hand-call.exp b/gdb/testsuite/gdb.threads/interrupted-hand-call.exp
index 926c612..2b0d8f2 100644
--- a/gdb/testsuite/gdb.threads/interrupted-hand-call.exp
+++ b/gdb/testsuite/gdb.threads/interrupted-hand-call.exp
@@ -27,14 +27,6 @@ if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executab
return -1
}
-# Some targets can't do function calls, so don't even bother with this
-# test.
-if [target_info exists gdb,cannot_call_functions] {
- setup_xfail "*-*-*" 2416
- fail "This target can not call functions"
- continue
-}
-
gdb_exit
gdb_start
gdb_reinitialize_dir $srcdir/$subdir
diff --git a/gdb/testsuite/gdb.threads/thread-unwindonsignal.exp b/gdb/testsuite/gdb.threads/thread-unwindonsignal.exp
index bacbe4c..203fb48 100644
--- a/gdb/testsuite/gdb.threads/thread-unwindonsignal.exp
+++ b/gdb/testsuite/gdb.threads/thread-unwindonsignal.exp
@@ -26,14 +26,6 @@ if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executab
return -1
}
-# Some targets can't do function calls, so don't even bother with this
-# test.
-if [target_info exists gdb,cannot_call_functions] {
- setup_xfail "*-*-*" 2416
- fail "This target can not call functions"
- continue
-}
-
gdb_exit
gdb_start
gdb_reinitialize_dir $srcdir/$subdir
--
1.7.0.4