This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add support for Tilera TILE-Gx processor (part 2/2: gdb)

On 04/20/2012 11:09 AM, Yao Qi wrote:
I don't know tile-gx processor at all, but some comments on code style. 
diff -r -u -N ./gdb-7.4.50.20120410/gdb/tilegx-linux-nat.c
./gdb/tilegx-linux-nat.c
--- ./gdb-7.4.50.20120410/gdb/tilegx-linux-nat.c        1969-12-31
19:00:00.000000000 -0500
+++ ./gdb/tilegx-linux-nat.c    2012-04-19 13:55:56.376489000 -0400
@@ -0,0 +1,188 @@
+
+void
+supply_gregset (struct regcache* regcache,
+               const elf_gregset_t *gregsetp)
Can be `static'? Function name "tilegx_supply_gregset" is better.



Yao,

I modeled this, and the other "regset" routines, on existing code (e.g., sparc64-, hppa-, alpha-, s390-, ppc-) that all implement supply_gregset() and expose that name for use by processor independent code. See procfs.c: procfs_fetch_registers() and core-regset.c: fetch_core_registers() for uses. supply_gregset is declared in gregset.h.

Unless there is now a better way to do it I will leave this as it is.

Thank you.

--jeff

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]