This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC/PATCH] Clean up unused variables (and prepare for `-Wunused-variable' flag)
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Pedro Alves <palves at redhat dot com>, Sergio Durigan Junior <sergiodj at redhat dot com>, gdb-patches at sourceware dot org
- Date: Tue, 24 Apr 2012 18:49:16 +0100
- Subject: Re: [RFC/PATCH] Clean up unused variables (and prepare for `-Wunused-variable' flag)
- References: <m3ty0at632.fsf@redhat.com> <4F968B4D.3050209@redhat.com> <87wr55do66.fsf@fleche.redhat.com>
On 04/24/2012 06:39 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> There's no need to commit all this in one go. Once you split,
> Pedro> some of the resulting patches will be dead obvious, and will end up
> Pedro> reviewed (if even necessary) and checked in quickly, and thus you end up
> Pedro> making progress faster that way.
>
> It seems to me that a variable that is declared but not initialized and
> not used is always going to be obviously dead. I'd be comfortable with
> pre-approving all such removals; leaving review for the patches to the
> generators and initialized variables.
Yes, that seems like a good cut.
--
Pedro Alves