This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3] gdbserver: uclinux: pull in ptrace offset definitions from asm/ptrace.h


On 04/26/2012 07:03 PM, Will Deacon wrote:

> 2012-04-26  Will Deacon  <will.deacon@arm.com>
> 
> 	* linux-low.c: Pull in PT_TEXT_ADDR, PT_TEXT_END_ADDR and
> 	PT_DATA_ADDR definitions from asm/ptrace.h.


This needs tweaking to conform to the GNU Coding Standards.  Write as:

	* linux-low.c [__UCLIBC__ && !(__UCLIBC_HAS_MMU__ || __ARCH_HAS_MMU__)]:
        Include asm/ptrace.h.
	(PT_TEXT_ADDR, PT_DATA_ADDR, PT_TEXT_END_ADDR): Define only if not
	already defined.

Okay with this, and the formatting issues pointed out by Mike fixed.

Though I do think that we don't need to worry about only a subset being defined...

Thanks guys.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]