This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] microMIPS support


On Fri, 27 Apr 2012, Eli Zaretskii wrote:

> >  So may I suggest fixing the release process to use the intended locale 
> > instead (C or en_US, or whatever)?
> 
> I don't know enough about the GDB releases to tell if this is
> practical.
> 
> Anyway, I try to keep all index entries start with a lower-case
> letter.  This is more reliable than imposing a certain locale on the
> environment where the release tarballs are made.

 I believe we already rely on this in some places.

> >  I'll see what I can do about it then, if that satisfies you.  However I 
> > still have troubles to accept this requirement.  So if the first word had 
> > to be a city or person's name, you'd demand it to start with a small 
> > letter too?
> 
> We don't have person names or cities in the GDB manual.  A manual that
> has many of these in the indices should probably consistently use
> capitalization of the first word in the index entries.

 I've just checked a random book that I have handy, that is "MIPS R4000 
Microprocessor User's Manual" and they mix cases in the index just fine on 
the similar principles that I'm referring to here.  As does "The Cambridge 
Grammar of the English Language" (a reference of a better authority 
probably, but only available in hard copy, so you may not have one readily 
available to check yourself).

 Therefore it doesn't appear to me starting index entries with a letter of 
any particular case is a requirement in English literature (being a 
non-native English speaker I have to rely on references).

> > I just don't buy it, sorry, there's something wrong with the process
> > if you must make such requirements.
> 
> I don't understand why it matters to you so much, sorry.

 It matters to me because I'm a user of this manual too and have troubles 
understanding the constraints you impose.

> > Do you really like the outcome, like an empty "ARM" subsection with
> > a lone reference to its "Breakpoint Kinds" subsubsection?  I find it
> > an unnecessary hassle to go through when reading the manual.
> 
> There's no need to have empty subsections or nodes.  Please delete
> those empty nodes.  All I asked was to have a node where you have a
> subsection with some content.  There's no need to introduce
> subsections or node with no content at all.

 These subsections already exist and make sense to me, grouping 
architecture-specific features by architecture -- and look good to me, in 
a formatting intended for printing, such as PDF, at least.  There's 
nothing I am trying to add here that doesn't follow what already exists. 
I'm not going to remove them and at this point you've got me tired enough 
arguing, sorry, so I am withdrawing my proposal.

 Here's the change as you originally required, minus the new node request, 
because it cannot be fulfilled without either revamping the whole section 
(which is something you specifically did not request and I only 
voluntarily offered, but have now withdrawn as I am not going to put my 
name on changes I am not happy with) or breaking the build -- I get:

gdb/doc/gdb.texinfo:36670: `MIPS Breakpoint Kinds' has no Up field (perhaps incorrect sectioning?).

if I add a lone @node definition, or that plus:

gdb/doc/gdb.texinfo:36670: warning: unreferenced node `MIPS Breakpoint Kinds'.

if I place a @menu reference to that node in any of the upper sections.  
Therefore I am not going to commit a change that will stop the build from 
working and I still believe adding these manual sections in their current 
form is better than dropping them altogether.

 Feel free to make any further adjustments as you see fit.  I'll be 
pushing it in this form as soon as the MIPS16 manual function call change 
has been committed.  This has been verified to build and render correctly.

 Thanks for your review.

  Maciej

gdb-micromips-info.diff
Index: gdb-fsf-trunk-quilt/gdb/doc/gdb.texinfo
===================================================================
--- gdb-fsf-trunk-quilt.orig/gdb/doc/gdb.texinfo	2012-04-30 23:58:16.000000000 +0100
+++ gdb-fsf-trunk-quilt/gdb/doc/gdb.texinfo	2012-05-01 00:22:11.225562002 +0100
@@ -20377,6 +20377,38 @@ default).
 @kindex show mips abi
 Show the MIPS ABI used by @value{GDBN} to debug the inferior.
 
+@item set mips compression @var{arg}
+@kindex set mips compression
+@cindex code compression, @acronym{MIPS}
+Tell @value{GDBN} which @acronym{MIPS} compressed
+@acronym{ISA, Instruction Set Architecture} encoding is used by the
+inferior.  @value{GDBN} uses this for code disassembly and other
+internal interpretation purposes.  This setting is only referred to
+when no executable has been associated with the debugging session or
+the executable does not provide information about the encoding it uses.
+Otherwise this setting is automatically updated from information
+provided by the executable.
+
+Possible values of @var{arg} are @samp{mips16} and @samp{micromips}.
+The default compressed @acronym{ISA} encoding is @samp{mips16}, as
+executables containing @acronym{MIPS16} code frequently are not
+identified as such.
+
+This setting is ``sticky''; that is, it retains its value across
+debugging sessions until reset either explicitly with this command or
+implicitly from an executable.
+
+The compiler and/or assembler typically add symbol table annotations to
+identify functions compiled for the @acronym{MIPS16} or
+@acronym{microMIPS} @acronym{ISA}s.  If these function-scope annotations
+are present, @value{GDBN} uses them in preference to the global
+compressed @acronym{ISA} encoding setting.
+
+@item show mips compression
+@kindex show mips compression
+Show the @acronym{MIPS} compressed @acronym{ISA} encoding used by
+@value{GDBN} to debug the inferior.
+
 @item set mipsfpu
 @itemx show mipsfpu
 @xref{MIPS Embedded, set mipsfpu}.
@@ -36635,6 +36667,27 @@ as @code{MIPS32}.
 
 @end table
 
+@subsubsection Breakpoint Kinds
+@cindex breakpoint kinds, @acronym{MIPS}
+
+These breakpoint kinds are defined for the @samp{Z0} and @samp{Z1} packets.
+
+@table @r
+
+@item 2
+16-bit @acronym{MIPS16} mode breakpoint.
+
+@item 3
+16-bit @acronym{microMIPS} mode breakpoint.
+
+@item 4
+32-bit standard @acronym{MIPS} mode breakpoint.
+
+@item 5
+32-bit @acronym{microMIPS} mode breakpoint.
+
+@end table
+
 @node Tracepoint Packets
 @section Tracepoint Packets
 @cindex tracepoint packets


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]