This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH][SH] Signal handler unwinding for SH-Linux
- From: Chung-Lin Tang <cltang at codesourcery dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: <gdb-patches at sourceware dot org>, Thomas Schwinge <thomas_schwinge at mentor dot com>
- Date: Mon, 7 May 2012 21:18:56 +0800
- Subject: Re: [PATCH][SH] Signal handler unwinding for SH-Linux
- References: <4F9CF631.9080807@codesourcery.com> <20120502215148.GC15555@adacore.com>
On 2012/5/3 05:51 AM, Joel Brobecker wrote:
> Overall, this looks good to me. I do not know about SH specifically,
> so I will take your word on the specific location and layout of the
> sigcontext structure.
>
> Just a small minor comment: All new functions and globals should
> be documented. Usually, when we implement a "virtual method" (a
> function destined to be used as a pointer in one of our generic
> structures; Eg. sh_linux_sigreturn_init), we do not repeat description.
> We just say that this function implements such and such callback
> in struct bla bla for such and such situation. The actual documentation
> should already be provided at the same location the field itself
> is declared.
>
> For instance, one possible description of sh_linux_sigreturn_init
> is:
>
> /* Implement struct tramp_frame's "init" callback for signal
> trampolines on 32-bit SH. */
Hi Joel, thanks for reviewing. I've committed the patch with minor
additional comments like you suggested.
Chung-Lin