This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] PR symtab/13277: Resolving opaque structures in ICC generated binaries. (testcase)
- From: John Steele Scott <toojays at toojays dot net>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Tom Tromey <tromey at redhat dot com>, Jan Kratochvil <jan dot kratochvil at redhat dot com>, gdb-patches at sourceware dot org
- Date: Sat, 12 May 2012 18:30:22 +0930
- Subject: Re: [patch] PR symtab/13277: Resolving opaque structures in ICC generated binaries. (testcase)
- References: <4E9A6F3C.6010400@toojays.net> <20111019084011.GA9326@host1.jankratochvil.net> <4EA3E995.8040206@toojays.net> <20111026221057.GA24628@host1.jankratochvil.net> <4EBFAC05.2070501@toojays.net> <m3bosdmi6p.fsf@fleche.redhat.com> <4FA49314.5020508@toojays.net> <20120505151557.GU15555@adacore.com>
Joel Brobecker <brobecker@adacore.com> writes:
>> Wow, I knew it would take a while, but it seems the papers got stuck
>> in limbo for several months.
>
> :-(. That is just not right. If I had known, I'd have pinged the FSF.
>
>> 2012-05-05 John Steele Scott <toojays@toojays.net>
>>
>> PR symtab/13277: Resolving opaque structures in ICC generated binaries.
>> * gdb.dwarf2/dw2-icc-opaque.S: New file.
>> * gdb.dwarf2/dw2-icc-opaque.exp: New file.
>
> The only issue I spotted with this patch is the copyright year, which
> needs to include 2012 as well, now. And while we are touching this,
> why not add a '(C)' as well. I know we're very inconsistent with this,
> but the the GNU Coding Standard shows it in all their example, and I
> have a feeling that they would rather we did. So:
>
> Copyright (C) 2011-2012 Free etc.
Updated patch is below.
> Not sure about the use of .asciz or not. We seem to have been using
> .ascii exclusively so far. Jan might know better whether that's ok.
I left the .asciz in; there is already a use of it in
testsuite/gdb.python/py-section-script.c.
For reference: the patch at
http://sourceware.org/ml/gdb-patches/2012-05/msg00144.html is required
for gdb to pass this test.
cheers,
John
2012-05-12 John Steele Scott <toojays@toojays.net>
PR symtab/13277: Resolving opaque structures in ICC generated binaries.
* gdb.dwarf2/dw2-icc-opaque.S: New file.
* gdb.dwarf2/dw2-icc-opaque.exp: New file.
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-icc-opaque.S b/gdb/testsuite/gdb.dwarf2/dw2-icc-opaque.S
new file mode 100644
index 0000000..4fc6512
--- /dev/null
+++ b/gdb/testsuite/gdb.dwarf2/dw2-icc-opaque.S
@@ -0,0 +1,192 @@
+/* Copyright (C) 2011-2012 Free Software Foundation, Inc.
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 3 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>. */
+
+ .file "opaque-pointer.c"
+ .data
+ .comm p_struct,8,8
+ .global p_struct#
+
+ .section .debug_info
+ .align 1
+debug_info_seg1:
+ .4byte debug_info_seg1_end - 1f /* Length of compilation unit info. */
+1:
+ .2byte 0x0002 /* DWARF version number. */
+ .4byte .debug_abbrev_seg1 /* Points to abbrev section for this unit. */
+ .byte 0x08 /* Target address size. */
+
+ .byte 0x01 /* DIE 1: DW_TAG_compile_unit. */
+ .byte 0x01 /* DW_AT_language = DW_LANG_C89. */
+ .ascii "Intel(R) C Intel(R) 64 Compiler XE " /* DW_AT_producer. */
+ .ascii "for applications running on Intel(R) 64, "
+ .ascii "Version 12.0.4.191 Build 20110427\n "
+ .asciz "Fixes SameLinkageName MemberPointers"
+
+ .byte 0x02 /* DIE 2: DW_TAG_variable. */
+ .byte 0x01 /* DW_AT_accessibility. */
+ .asciz "p_struct" /* DW_AT_name. */
+ .4byte 3f - debug_info_seg1 /* DW_AT_type. */
+ .2byte 0x0309 /* DW_AT_location: 9 bytes, DW_OP_addr */
+ .8byte p_struct /* followed by the address of p_struct. */
+ .byte 0x01 /* DW_AT_external. */
+
+3:
+ .byte 0x03 /* DIE 3: DW_TAG_pointer_type. */
+ .4byte 4f - debug_info_seg1 /* DW_AT_type. */
+
+4:
+ .byte 0x04 /* DIE 4: DW_TAG_structure_type. */
+ .byte 0x01 /* DW_AT_accessibility. */
+ .byte 0x00 /* DW_AT_byte_size. */
+ .asciz "opaque_struct_t" /* DW_AT_name. */
+ .byte 0x00
+ .byte 0x00
+ .byte 0x00
+ .byte 0x00
+debug_info_seg1_end:
+
+ .section .debug_abbrev
+.debug_abbrev_seg1:
+ .align 1
+ .byte 0x01 /* Abbrev 1. */
+ .byte 0x11 /* DW_TAG_compile_unit. */
+ .byte 0x01 /* DW_CHILDREN_yes. */
+ .byte 0x13 /* DW_AT_language. */
+ .byte 0x0b /* DW_FORM_data1. */
+ .byte 0x25 /* DW_AT_producer. */
+ .byte 0x08 /* DW_AT_string. */
+ .2byte 0x0000 /* End abbrev. */
+
+ .byte 0x02 /* Abbrev 2. */
+ .byte 0x34 /* DW_TAG_variable. */
+ .byte 0x00 /* DW_CHILDREN_no. */
+ .byte 0x32 /* DW_AT_accessibility. */
+ .byte 0x0b /* DW_FORM_data1. */
+ .byte 0x03 /* DW_AT_name. */
+ .byte 0x08 /* DW_FORM_string. */
+ .byte 0x49 /* DW_AT_type. */
+ .byte 0x13 /* DW_FORM_ref4. */
+ .byte 0x02 /* DW_AT_location. */
+ .byte 0x0a /* DW_FORM_block1. */
+ .byte 0x3f /* DW_AT_external. */
+ .byte 0x0c /* DW_FORM_flag. */
+ .2byte 0x0000 /* End abbrev. */
+
+ .byte 0x03 /* Abbrev 3. */
+ .byte 0x0f /* DW_TAG_pointer_type. */
+ .byte 0x00 /* DW_CHILDREN_no. */
+ .byte 0x49 /* DW_AT_type. */
+ .byte 0x13 /* DW_FORM_ref4. */
+ .2byte 0x0000 /* End abbrev. */
+
+ .byte 0x04 /* Abbrev 4. */
+ .byte 0x13 /* DW_TAG_structure_type. */
+ .byte 0x00 /* DW_CHILDREN_no. */
+ .byte 0x32 /* DW_AT_accessibility. */
+ .byte 0x0b /* DW_FORM_data1. */
+ .byte 0x0b /* DW_AT_byte_size. */
+ .byte 0x0b /* DW_FORM_data1. */
+ .byte 0x03 /* DW_AT_name. */
+ .byte 0x08 /* DW_FORM_string. */
+ .2byte 0x0000 /* End abbrev. */
+ .byte 0x00 /* End abbrev table. */
+
+
+ .file "opaque-struct.c"
+ .section .debug_info
+ .align 1
+debug_info_seg2:
+ .4byte debug_info_seg2_end - 1f /* Length of compilation unit info. */
+1:
+ .2byte 0x0002 /* DWARF version number. */
+ .4byte .debug_abbrev_seg2 /* Points to abbrev section for this unit. */
+ .byte 0x08 /* Target address size. */
+
+ .byte 0x01 /* DIE 1: DW_TAG_compile_unit. */
+ .byte 0x01 /* DW_AT_language = DW_LANG_C89. */
+ .ascii "Intel(R) C Intel(R) 64 Compiler XE " /* DW_AT_producer. */
+ .ascii "for applications running on Intel(R) 64, "
+ .ascii "Version 12.0.4.191 Build 20110427\n "
+ .asciz "Fixes SameLinkageName MemberPointers"
+
+ .byte 0x02 /* DIE 2: DW_TAG_structure_type. */
+ .byte 0x01 /* DW_AT_accessibility. */
+ .byte 0x04 /* DW_AT_byte_size. */
+ .asciz "opaque_struct_t" /* DW_AT_name. */
+
+
+ .byte 0x03 /* DIE 3: DW_TAG_member. */
+ .2byte 0x2302 /* DW_AT_data_member_location, 2 bytes, */
+ .byte 0x00 /* DW_OP_plus_uconst followed by zero. */
+ .asciz "wrapped_value" /* DW_AT_name. */
+ .4byte 4f - debug_info_seg2 /* DW_AT_type. */
+ .byte 0x00
+
+4:
+ .byte 0x04 /* DIE 4: DW_TAG_base_type. */
+ .byte 0x04 /* DW_AT_byte_size. */
+ .byte 0x05 /* DW_AT_encoding. */
+ .asciz "int" /* DW_AT_name. */
+ .byte 0x00
+ .byte 0x00
+ .byte 0x00
+ .byte 0x00
+debug_info_seg2_end:
+
+ .section .debug_abbrev
+.debug_abbrev_seg2:
+ .align 1
+ .byte 0x01 /* Abbrev 1. */
+ .byte 0x11 /* DW_TAG_compile_unit. */
+ .byte 0x01 /* DW_CHILDREN_yes. */
+ .byte 0x13 /* DW_AT_language. */
+ .byte 0x0b /* DW_FORM_data1. */
+ .byte 0x25 /* DW_AT_producer. */
+ .byte 0x08 /* DW_FORM_string. */
+ .2byte 0x0000 /* End abbrev. */
+
+ .byte 0x02 /* Abbrev 2. */
+ .byte 0x13 /* DW_TAG_structure_type. */
+ .byte 0x01 /* DW_CHILDREN_yes. */
+ .byte 0x32 /* DW_AT_accessibility. */
+ .byte 0x0b /* DW_FORM_data1. */
+ .byte 0x0b /* DW_AT_byte_size. */
+ .byte 0x0b /* DW_FORM_data1. */
+ .byte 0x03 /* DW_AT_name. */
+ .byte 0x08 /* DW_FORM_string. */
+ .2byte 0x0000 /* End abbrev. */
+
+ .byte 0x03 /* Abbrev 3. */
+ .byte 0x0d /* DW_TAG_member. */
+ .byte 0x00 /* DW_CHILDREN_no. */
+ .byte 0x38 /* DW_AT_data_member_location. */
+ .byte 0x0a /* DW_FORM_block1. */
+ .byte 0x03 /* DW_AT_name. */
+ .byte 0x08 /* DW_FORM_string. */
+ .byte 0x49 /* DW_AT_type. */
+ .byte 0x13 /* DW_FORM_ref4. */
+ .2byte 0x0000 /* End abbrev. */
+
+ .byte 0x04 /* Abbrev 4. */
+ .byte 0x24 /* DW_TAG_base_type. */
+ .byte 0x00 /* DW_CHILDREN_no. */
+ .byte 0x0b /* DW_AT_byte_size. */
+ .byte 0x0b /* DW_FORM_data1. */
+ .byte 0x3e /* DW_AT_encoding. */
+ .byte 0x0b /* DW_FORM_data1. */
+ .byte 0x03 /* DW_AT_name. */
+ .byte 0x08 /* DW_FORM_string. */
+ .2byte 0x0000 /* End abbrev. */
+ .byte 0x00 /* End abbrev table. */
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-icc-opaque.exp b/gdb/testsuite/gdb.dwarf2/dw2-icc-opaque.exp
new file mode 100644
index 0000000..53db400
--- /dev/null
+++ b/gdb/testsuite/gdb.dwarf2/dw2-icc-opaque.exp
@@ -0,0 +1,37 @@
+# Copyright (C) 2011-2012 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+load_lib dwarf.exp
+
+# This test can only be run on targets which support DWARF-2 and use gas.
+if {![dwarf2_support]} {
+ return 0
+}
+
+set testfile "dw2-icc-opaque"
+set srcfile ${testfile}.S
+set executable ${testfile}.x
+set binfile ${objdir}/${subdir}/${executable}
+
+if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" object {}] != "" } {
+ return -1
+}
+
+clean_restart $executable
+
+# Before PR 13277 was fixed, this would output:
+# type = struct opaque_struct_t {
+# <no data fields>
+# } *
+gdb_test "ptype p_struct" "type = struct opaque_struct_t {\r\n *int wrapped_value;\r\n} \\*"