This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 1/2] mips: Switch inferior function calls to ON_STACK method.


>  I gave it yet more thinking and came to the conclusion that at least
>  for the MIPS target, where it is safe to use either way, but both
>  have some drawbacks, we should really apply both, switching
>  dynamically.  The reason is the stack may be unwritable for whatever
>  reason (e.g. not correctly set up), so we should try ON_STACK first
>  and if that fails (e.g. SP is NULL or writing to the stack has
>  faulted), then fall back to AT_ENTRY_POINT.  This is another corner
>  case however and I don't feel compelled to implement it right now.
>  Let's leave it for another sunny day in Cambridgeshire. ;)

Is that something we could detect at gdbarch init? (I don't think we
have a process at init time)

> 2012-05-14  Maciej W. Rozycki  <macro@codesourcery.com>
> 
> 	gdb/
> 	* mips-tdep.c (mips_push_dummy_code): Handle microMIPS code.

FWIW, the change looks good to me.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]