This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit] testsuite: gdb.base/dprintf.exp PR 12649 race [Re: [PATCH v2] dynamic printf]
On Mon, 14 May 2012 17:53:50 +0200, Stan Shebs wrote:
> Thanks for the feedback! Here's what I committed.
seeing racy results
+Running gdb/testsuite/gdb.base/dprintf.exp ...
+FAIL: gdb.base/dprintf.exp: dprintf
+PASS: gdb.base/dprintf.exp: dprintf foo
+PASS: gdb.base/dprintf.exp: dprintf 29
+ERROR: breakpoints not deleted
+UNRESOLVED: gdb.base/dprintf.exp: dprintf foo,"At foo entry\n"
with the read1 reproducer from
http://sourceware.org/bugzilla/show_bug.cgi?id=12649
it shows:
(gdb) run ^M
Starting program: /home/jkratoch/redhat/gdb-clean/gdb/testsuite/gdb.base/dprintf ^M
dprintf^M
warning: Skipping deprecated .gdb_index section in /usr/lib/debug/lib64/ld-2.15.so.debug, pass --use-deprecated-index-sections to use them anyway^M
^M
Breakpoint 1, main (argc=1, argv=0x7fffffffdb98) at ./gdb.base/dprintf.c:33^M
33 int loc = 1234;^M
(gdb) FAIL: gdb.base/dprintf.exp: dprintf
Checked in the fix.
Regards,
Jan
http://sourceware.org/ml/gdb-cvs/2012-05/msg00107.html
--- src/gdb/testsuite/ChangeLog 2012/05/14 20:33:16 1.3189
+++ src/gdb/testsuite/ChangeLog 2012/05/15 13:08:57 1.3190
@@ -1,3 +1,8 @@
+2012-05-15 Jan Kratochvil <jan.kratochvil@redhat.com>
+
+ PR testsuite/12649
+ * gdb.base/dprintf.exp: Replace gdb_run_cmd by runto main.
+
2012-05-14 Sergio Durigan Junior <sergiodj@redhat.com>
* gdb.base/stap-probe.exp (stap_test): Remove calls to
--- src/gdb/testsuite/gdb.base/dprintf.exp 2012/05/14 15:38:41 1.1
+++ src/gdb/testsuite/gdb.base/dprintf.exp 2012/05/15 13:08:58 1.2
@@ -24,7 +24,9 @@
set dp_location1 [gdb_get_line_number "set dprintf 1 here"]
gdb_breakpoint "main"
-gdb_run_cmd
+if ![runto main] {
+ return -1
+}
gdb_test "dprintf" "Format string required"