This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[commit] info-macros.exp: Pass "debug" to prepare_for_testing


Hi.

This test was failing under Fission when run with the full testsuite and
passing when run by itself.
I test Fission with a board file which sets debug_flags,
but debug_flags doesn't get used unless "debug" is passed as a build option.
So when run by itself "options" was "" and thus the Fission compilation
flags weren't getting picked up, but I guess when run with the full testsuite
this test was picking up a value of options that contained "debug".

Committed.

2012-05-17  Doug Evans  <dje@google.com>

	* info-macros.exp: Pass "debug" to prepare_for_testing.

Index: info-macros.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/info-macros.exp,v
retrieving revision 1.3
diff -u -p -r1.3 info-macros.exp
--- info-macros.exp	4 Jan 2012 08:17:46 -0000	1.3
+++ info-macros.exp	18 May 2012 00:03:01 -0000
@@ -16,14 +16,15 @@
 set testfile "info-macros"
 set srcfile ${testfile}.c
 set binfile ${objdir}/${subdir}/${testfile}
+
 get_compiler_info ${binfile}
-if [test_compiler_info gcc*] {
-    lappend options additional_flags=-g3
-} else {
+if ![test_compiler_info gcc*] {
   untested ${testfile}.exp
   return -1
 }
 
+set options "debug additional_flags=-g3"
+
 if { [prepare_for_testing ${testfile}.exp ${testfile} ${srcfile} $options] } {
     untested ${testfile}.exp
     return -1


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]