This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patchv2] PR c++/14177 - Fix parsing TYPENAME:: in parentheses
- From: Tom Tromey <tromey at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 08 Jun 2012 10:13:48 -0600
- Subject: Re: [patchv2] PR c++/14177 - Fix parsing TYPENAME:: in parentheses
- References: <20120530223043.GA9608@host2.jankratochvil.net> <20120531013751.GA19513@host2.jankratochvil.net>
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> I am very unsure with the C++ parser code but it seems OK to me.
I wonder if we should just get rid of the extension here.
I think Keith added it because it lets you avoid quoting in expressions.
But since it is an extension it means an ongoing struggle to make the
parser correctly parse valid things...
That is, does this need to be valid?
Jan> +gdb_test "p CV_f(CV::t)" { = {int \(int\)} 0x[0-9a-f]+ <CV_f\(int\)>}
Jan> +int arglist_typeinstance;
I think it would be preferable to make this local to c-exp.y and just
clear it at the few spots that start_arglist is called.
Otherwise it all seems ok to me.
Tom