This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Add global/static and symbol kind indicator to .gdb_index


On Tue, Jun 19, 2012 at 9:07 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> cc: ccoutant@google.com
>> Date: Tue, 19 Jun 2012 00:49:31 -0700 (PDT)
>> From: dje@google.com (Doug Evans)
>>
>> This patch adds a global/static bit and a symbol kind indicator
>> to CU values in .gdb_index.
>
> Thanks. ?I have a few comments about the documentation part:
>
>> +If a symbol has multiple uses within a CU then there is one
>> +CU index+attributes value for each different use.
>
> I would lose the "different" part, it's redundant here.
>
>> +@item 0
>> +This value is reserved and not to be used.
> ? ? ? ? ? ? ? ? ? ? ? ? ?^^^^^^^^^^^^^^^^^^
> "and should not be used"
>
>> +@item 2
>> +The symbol is a variable.
>> +Enum values are also included.
>
> Not sure what the last sentence means. ?Value is not a symbol. ?Do you
> mean "the symbol is a name of a variable or of an enum"?
>
> And, if my reading of the code is correct, we should mention constants
> here.
>
>> +@item 4
>> +The symbol is not covered by the other kinds.
>
> I think this is better:
>
> ?Any other kind of symbol.
>
>> +@item Bit 31
>> +This bit is zero if the value is ``global'' and one if it is ``static''.
>
> Do we really need the quotes here?

This patch addresses the doc issues, and fixes a thinko where I didn't
check for older indices when testing the symbol kind.

2012-06-19  Doug Evans  <dje@google.com>

        PR 14125
        * dwarf2read.c: #include "gdb/gdb-index.h".
        (DW2_GDB_INDEX_SYMBOL_STATIC_SET_VALUE): New macro.
        (DW2_GDB_INDEX_SYMBOL_KIND_SET_VALUE): New macro.
        (DW2_GDB_INDEX_CU_SET_VALUE): New macro.
        (dwarf2_read_index): Recognize version 7.
        (dw2_do_expand_symtabs_matching): New args want_specific_block,
        block_kind, domain): All callers updated.
        (dw2_find_symbol_file): Handle new index CU values.
        (dw2_expand_symtabs_matching): Match symbol kind if requested.
        (add_index_entry): New args is_static, kind.  All callers updated.
        (offset_type_compare, uniquify_cu_indices): New functions
        (symbol_kind): New function.
        (write_psymtabs_to_index): Remove duplicate CU values.
        (write_psymtabs_to_index): Write .gdb_index version 7.

        doc/
        * gdb.texinfo (Index Section Format): Document version 7 format.

        include/
        * gdb/gdb-index.h: New file.

Attachment: gdb-120619-gdb-index-attrs-2.patch.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]