This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH]Fix that GDB will get hang on Windows when using pipe to get stdout and stderr from stub
- From: "Terry Guo" <terry dot guo at arm dot com>
- To: "'Sergio Durigan Junior'" <sergiodj at redhat dot com>
- Cc: "Eli Zaretskii" <eliz at gnu dot org>, <gdb-patches at sourceware dot org>
- Date: Tue, 17 Jul 2012 11:06:45 +0800
- Subject: RE: [PATCH]Fix that GDB will get hang on Windows when using pipe to get stdout and stderr from stub
- References: <000001cd5338$ded61b20$9c825160$%guo@arm.com> <83hatw8zn1.fsf@gnu.org> <000301cd59bd$ce1c8900$6a559b00$%guo@arm.com> <000101cd5f22$2371cdc0$6a556940$%guo@arm.com> <83k3yab0x6.fsf@gnu.org> <000301cd5fcf$838d31b0$8aa79510$%guo@arm.com> <83ehohblor.fsf@gnu.org> <000001cd6317$2d714cd0$8853e670$@guo@arm.com> <m38vejuqfd.fsf@redhat.com>
> > +/* Read any error output we might have. */
> > +
> > +static void
> > +ser_base_read_error_fd (struct serial *scb, int close_fd)
> > +{
> > + if (scb->error_fd != -1)
> > + {
> > + ssize_t s;
> > + char buf[GDB_MI_MSG_WIDTH + 1];
> > +
> > + for (;;)
> > + {
> > + char *current;
>
> I notice you are not following the convention of converting 8 spaces to
> a TAB character here and everywhere else. Can you please fix it?
> After
> that, I can commit the patch for (if you don't have the permission yet).
>
Hi Sergio,
Thanks very much. I will fix them and re-send the patch for review.
BR,
Terry