This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/9] add registry.h, change existing users


>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> One thing I notice is that this leave everything templatized,
Pedro> while it is possible to factor most things out, leaving only the
Pedro> templating as a shim (like in C++ you would push the common code
Pedro> to a base class that handles void*, and then derive a template
Pedro> shim on top that just converts pointers).  Something like this.
Pedro> This would impact your following patches, so if you prefer and
Pedro> agree it's a good idea, I'll get back to it only after your
Pedro> patches are in.

It seems reasonable to me.  For me the most important thing is that the
public API remain type-safe -- I think macro-based approaches using
void* are too error-prone -- but your patch preserves that.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]