Re: RFC: fix PR 14386

[Phil Muldoon <pmuldoon at redhat dot com>]

On 08/01/2012 05:42 PM, Tom Tromey wrote:
> This fixes PR python/14386.
> 
> I'd like to commit this to the trunk and the 7.5 branch; the latter
> because it is a reasonably obvious, low-risk, and useful bug fix.
> 
> The bug here is that a certain libstdc++ pretty-printer doesn't work in
> MI.

Looks great to me.  The only comment I have has nothing to do with your
patch, but I will comment here for context.

It seems we wind-up printing two errors if the value returned to
"children" is not an iterator.  The "type error" exception that is
printed with gdbpy_print_stack, and then the explicit error call we call
right after.  Not sure if this is because of an MI detail needing an
"error" call, but it seems counter-intuitive to print two error
messages for one exception.  Maybe in a future patch we could extract
the exception message from the exception and pass that to the GDB
error call, or skip the error call completely.

Cheers,

Phil