This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[obv] testsuite: default.exp: Fix cd regression [Re: [commit] [PATCH] cd command defaults to ~]


On Mon, 06 Aug 2012 19:14:37 +0200, Jan Kratochvil wrote:
> On Mon, 06 Aug 2012 11:14:57 +0200, Nathaniel Flath wrote:
> > gdb/
> > 2012-07-21  Nathaniel Flath  <flat0103@gmail.com>
> > 
> >         * NEWS: New entry for 'cd' default parameters.
> >         * cli/cli-cmds.c (cd_command): Replace error_no_arg by DIR assignment.

It has caused:
	 cd
	-Argument required (new working directory).
	-(gdb) PASS: gdb.base/default.exp: cd
	+Working directory /home/jkratoch.
	+(gdb) FAIL: gdb.base/default.exp: cd

One should run a regression testsuite, I forgot you did not.

Checked in.


Jan


http://sourceware.org/ml/gdb-cvs/2012-08/msg00059.html

--- src/gdb/testsuite/ChangeLog	2012/08/06 20:14:10	1.3326
+++ src/gdb/testsuite/ChangeLog	2012/08/07 05:49:01	1.3327
@@ -1,3 +1,7 @@
+2012-08-07  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	* gdb.base/default.exp (cd): Accept new directory with no arguments.
+
 2012-08-06  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
 	* gdb.base/list.exp (test_only_end): New function.
--- src/gdb/testsuite/gdb.base/default.exp	2012/04/27 20:52:06	1.59
+++ src/gdb/testsuite/gdb.base/default.exp	2012/08/07 05:49:02	1.60
@@ -84,7 +84,7 @@
 gdb_test "catch" "Catch requires an event name..*" "catch"
 
 #test cd
-gdb_test "cd" "Argument required .new working directory.*" "cd"
+gdb_test "cd" "Working directory \[^\r\n\]*\\."
 
 #test clear
 gdb_test "clear" "No source file specified..*" "clear"


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]