This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA, doc RFA] Implement $_memeq, $_streq, $_strlen


>>>>> "Doug" == Douglas Evans <dje@google.com> writes:

Doug> +  ** $_memeq(buf1, buf2, length)
Doug> +  ** $_streq(str1, str2)

I don't really care, but I'm curious why you chose the eq forms instead
of the cmp forms.

[streq]
Doug> +    return a.string("iso-8859-1") == b.string("iso-8859-1")

I wonder whether this forces a constant string to inferior memory.
It would be nice to avoid that if possible.

The patch looks good, I think it is ok as-is.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]