This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/3] bitpos: Minor python changes for bitpos expansion
- From: Tom Tromey <tromey at redhat dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 10 Aug 2012 10:58:56 -0600
- Subject: Re: [PATCH 3/3] bitpos: Minor python changes for bitpos expansion
- References: <20120805005417.6e8d34d9@spoyarek>
>>>>> "Siddhesh" == Siddhesh Poyarekar <siddhesh@redhat.com> writes:
Siddhesh> This is the final (and the smallest) patch in the bitpos expansion
Siddhesh> changes. This patch changes python-types code to use
Siddhesh> PyLong_FromLongLong for bitpos and type.length.
Siddhesh> - arg = PyLong_FromLong (TYPE_FIELD_BITPOS (type, field));
Siddhesh> + arg = PyLong_FromLongLong (TYPE_FIELD_BITPOS (type, field));
I think this patch should use gdb_py_long_from_longest in both spots.
See python-internal.h.
Other than that, this is fine.
I think it could go in any time, it doesn't seem dependent on the main
patch.
Tom