This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/3] bitpos: Minor python changes for bitpos expansion


>>>>> "Siddhesh" == Siddhesh Poyarekar <siddhesh@redhat.com> writes:

Siddhesh> This is the final (and the smallest) patch in the bitpos expansion
Siddhesh> changes. This patch changes python-types code to use
Siddhesh> PyLong_FromLongLong for bitpos and type.length.

Siddhesh> -	  arg = PyLong_FromLong (TYPE_FIELD_BITPOS (type, field));
Siddhesh> +	  arg = PyLong_FromLongLong (TYPE_FIELD_BITPOS (type, field));

I think this patch should use gdb_py_long_from_longest in both spots.
See python-internal.h.

Other than that, this is fine.
I think it could go in any time, it doesn't seem dependent on the main
patch.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]