This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH/obv] Cleanups in gdbtypes.c
- From: Keith Seitz <keiths at redhat dot com>
- To: "gdb-patches at sourceware dot org ml" <gdb-patches at sourceware dot org>
- Date: Wed, 15 Aug 2012 16:44:49 -0700
- Subject: [PATCH/obv] Cleanups in gdbtypes.c
Hi,
While working on a bug, I noticed some trivial cleanups to gdbtypes.c.
I've committed the following changes as obvious:
2012-08-15 Keith Seitz <keiths@redhat.com>
* gdbtypes.c (opaque_type_resolution): Make static.
Add missing comment.
(overload_debug): Add missing comment.
(show_opaque_type_resolution): Likewise.
(show_overload_debug): Likewise.
(print_bit_vector): Remove unnecessary forward declaration.
(print_arg_types): Likewise.
(dump_fn_fieldlists): Likewise.
(print_cplus_stuff): Likewise.
Index: gdbtypes.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtypes.c,v
retrieving revision 1.238
diff -u -p -r1.238 gdbtypes.c
--- gdbtypes.c 14 Aug 2012 19:35:47 -0000 1.238
+++ gdbtypes.c 15 Aug 2012 23:42:14 -0000
@@ -110,7 +110,16 @@ const struct floatformat *floatformats_i
&floatformat_ibm_long_double
};
-int opaque_type_resolution = 1;
+/* Should opaque types be resolved? */
+
+static int opaque_type_resolution = 1;
+
+/* A flag to enable printing of debugging information of C++
+ overloading. */
+
+unsigned int overload_debug = 0;
+
+/* A function to show whether opaque types are resolved. */
static void
show_opaque_type_resolution (struct ui_file *file, int from_tty,
@@ -122,7 +131,7 @@ show_opaque_type_resolution (struct ui_f
value);
}
-unsigned int overload_debug = 0;
+/* A function to show whether C++ overload debugging is enabled. */
static void
show_overload_debug (struct ui_file *file, int from_tty,
@@ -132,10 +141,6 @@ show_overload_debug (struct ui_file *fil
value);
}
-static void print_bit_vector (B_TYPE *, int);
-static void print_arg_types (struct field *, int, int);
-static void dump_fn_fieldlists (struct type *, int);
-static void print_cplus_stuff (struct type *, int);
/* Allocate a new OBJFILE-associated type structure and fill it
with some defaults. Space for the type structure is allocated