This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Ping Re: Fix ARM stepping over Thumb-mode "bx pc" or "blx pc"
On Mon, 13 Aug 2012, Joseph S. Myers wrote:
> On Sat, 11 Aug 2012, Yao Qi wrote:
>
> > I don't have any preference on clearing either the last one bit in
> > address or the last two bits. Looks like two ways coexist in arm-tdep.c
> > nowadays. As 'pc_val' is set by MAKE_THUMB_ADDR at the beginning, it is
> > better to revert its change by using UNMAKE_THUMB_ADDR (which only
> > clears the last one bit of address).
>
> This version uses UNMAKE_THUMB_ADDR as requested. Tested with no
> regressions with cross to arm-none-linux-gnueabi.
>
> 2012-08-13 Joseph Myers <joseph@codesourcery.com>
>
> * arm-tdep.c (thumb_get_next_pc_raw): Mask off low bits for bx pc
> and blx pc.
>
> testsuite:
> 2012-08-13 Joseph Myers <joseph@codesourcery.com>
>
> * gdb.arch/thumb-bx-pc.S: New file.
> * gdb.arch/thumb-bx-pc.exp: New file.
Ping. This patch
<http://sourceware.org/ml/gdb-patches/2012-08/msg00368.html> is pending
review.
--
Joseph S. Myers
joseph@codesourcery.com