This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Set $trace_frame and $tracepoint on disconnect

From: Yao Qi <yao at codesourcery dot com>
To: Tom Tromey <tromey at redhat dot com>
Cc: <gdb-patches at sourceware dot org>
Date: Fri, 24 Aug 2012 00:16:56 +0800
Subject: Re: [PATCH] Set $trace_frame and $tracepoint on disconnect
References: <1345550573-24752-1-git-send-email-yao@codesourcery.com> <87zk5lpq5e.fsf@fleche.redhat.com>

On 08/23/2012 11:46 PM, Tom Tromey wrote:

Looks good to me.
I read your patch and traced through the various tracepoint.c functions.

Thanks for the review. Committed.

Just a side note on tracepoint.c - it seems bad to have functions named
"set_traceframe_num" and "set_traceframe_number" with different effects.
A bit of reading showed me what was going on, but the names seem
needlessly confusing.

Yes, here are some rooms to improve. I'll have a look.

--
Yao

References:
- [PATCH] Set $trace_frame and $tracepoint on disconnect
  - From: Yao Qi
- Re: [PATCH] Set $trace_frame and $tracepoint on disconnect
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]