This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/9] add registry.h, change existing users
- From: Tom Tromey <tromey at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 10 Sep 2012 09:20:09 -0600
- Subject: Re: [PATCH 2/9] add registry.h, change existing users
- References: <87mx2h5l8i.fsf@fleche.redhat.com> <50180898.7090109@redhat.com> <87d33as73j.fsf@fleche.redhat.com> <503E5D0C.9070202@redhat.com>
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> Here's the updated patch, now that yours is in.
Pedro> 2012-08-29 Pedro Alves <palves@redhat.com>
Pedro> gdb/
Pedro> * Makefile.in (COMMON_OBS): Add registry.o.
Pedro> * registry.c: New file.
Pedro> * registry.h (struct registry_container): Declare.
Pedro> (registry_data_callback): New typedef.
Pedro> (struct registry_data, struct registry_data_registration, struct
Pedro> registry_data_registry): New type.
Pedro> (register_data_with_cleanup, registry_alloc_data)
Pedro> (registry_callback_adaptor, registry_clear_data)
Pedro> (registry_container_free_data, registry_set_data, registry_data):
Pedro> Declare.
Pedro> (DEFINE_REGISTRY): Refactor structures and functions as shims over
Pedro> the new common structures and functions.
Pedro> (DECLARE_REGISTRY): Declare struct TAG ## _data. Use the tagged
Pedro> callback typedefs.
Looks good to me.
Tom