This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/4] new gdb_queue.h in common/.
- From: Tom Tromey <tromey at redhat dot com>
- To: dje at google dot com
- Cc: Yao Qi <yao at codesourcery dot com>, <gdb-patches at sourceware dot org>
- Date: Tue, 11 Sep 2012 10:49:55 -0600
- Subject: Re: [PATCH 1/4] new gdb_queue.h in common/.
- References: <1345775139-13576-1-git-send-email-yao@codesourcery.com> <1345775139-13576-2-git-send-email-yao@codesourcery.com> <20535.52070.49473.442620@ruffy2.mtv.corp.google.com> <503DE3E0.5070803@codesourcery.com> <20550.27760.260327.470212@ruffy2.mtv.corp.google.com>
>>>>> "Doug" == Douglas Evans <dje@google.com> writes:
Doug> Yeah, OTOH this is how "extended" versions of API functions come into being.
Doug> They're a wart in the API so I like to avoid them.
Doug> E.g. consider htab_create_alloc vs htab_create_alloc_ex in the hashtab API.
Doug> Some might not think this is a wart, alas I do, so this is one situation
Doug> where I don't like to lazily add stuff (when I'm aware of it at
Doug> the time ... :-)).
Doug> OTOOH, since we're lazily adding the object version of the API anyway,
Doug> I don't feel too strongly about it here.
I think the difference is that if the code is all in gdb, then a change
can also easily update all uses. This isn't true for hashtab.
Tom