This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch+7.5?] Fix GDB-return into TAILCALL_FRAME (PR 14119)
- From: Tom Tromey <tromey at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 13 Sep 2012 14:43:07 -0600
- Subject: Re: [patch+7.5?] Fix GDB-return into TAILCALL_FRAME (PR 14119)
- References: <20120912180235.GA13250@host2.jankratochvil.net>
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> I am not completely sure the patch in skip_inlined_frames is
Jan> appropriate for all the callers of skip_inlined_frames but it seems
Jan> so to me, frame_id of TAILCALL_FRAME is artifical the same way like
Jan> INLINE_FRAME is.
This argument is persuasive, but the patch still makes me a bit nervous,
just because the concrete details at each call point may matter.
It seems some comments need updating, e.g., inline_depth is overloaded
but the comment doesn't indicate this.
Jan> No regressions on {x86_64,x86_64-m32,i686}-fedora18-linux-gnu.
Jan> I would think this should be even for 7.5.
Me too. I'm inclined to say it should go in.
Tom