This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/3] Make jit-reader-load accept absolute paths to reader shared objects.

From: Tom Tromey <tromey at redhat dot com>
To: Eli Zaretskii <eliz at gnu dot org>
Cc: Sanjoy Das <sanjoy at playingwithpointers dot com>, gdb-patches at sourceware dot org
Date: Tue, 18 Sep 2012 13:20:54 -0600
Subject: Re: [PATCH 2/3] Make jit-reader-load accept absolute paths to reader shared objects.
References: <1347942847-31510-1-git-send-email-sanjoy@playingwithpointers.com> <1347942847-31510-3-git-send-email-sanjoy@playingwithpointers.com> <83obl324vf.fsf@gnu.org>

>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:

>> +  if (args[0] == '/')

Eli> Why not use IS_ABSOLUTE_PATH here?  That would make the code more
Eli> portable.

I agree.  The code bits are ok with that change.

Tom

References:
- [PATCH 0/3] Fix recent breakage in the JIT reader interface
  - From: Sanjoy Das
- [PATCH 2/3] Make jit-reader-load accept absolute paths to reader shared objects.
  - From: Sanjoy Das
- Re: [PATCH 2/3] Make jit-reader-load accept absolute paths to reader shared objects.
  - From: Eli Zaretskii

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]