This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/2]: Refactor relocate_path to also check if the relocated file/directory exists

From: Khoo Yit Phang <khooyp at cs dot umd dot edu>
To: Andreas Schwab <schwab at linux-m68k dot org>
Cc: Khoo Yit Phang <khooyp at cs dot umd dot edu>, Jan Kratochvil <jan dot kratochvil at redhat dot com>, Eli Zaretskii <eliz at gnu dot org>, gdb-patches at sourceware dot org
Date: Sat, 22 Sep 2012 12:06:43 -0400
Subject: Re: [PATCH 1/2]: Refactor relocate_path to also check if the relocated file/directory exists
References: <21ACC598-F6B4-4117-BA7B-B316414DE9E3@cs.umd.edu> <20120919130040.GA20442@host2.jankratochvil.net> <F768B2DD-1531-4911-9732-DAE6D346F159@cs.umd.edu> <20120921182637.GA8747@host2.jankratochvil.net> <83y5k3w7es.fsf@gnu.org> <20120921184623.GA12696@host2.jankratochvil.net> <m2sjab9os3.fsf@igel.home>

Hi,

On Sep 21, 2012, at 3:09 PM, Andreas Schwab wrote:

> Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> 
>> It would have to be written as:
>>  	  if (stat (path, &s) != 0 || !isdir != !S_ISDIR (s.st_mode))
> 
> A common idiom is to use !! when the other side is already boolean.

I like this idiom, it does seem to be used in GDB, and isdir should be a boolean. Here's a patch that uses it.

Yit
September 22, 2012

Attachment: refactor-relocate-path.txt
Description: Text document

Follow-Ups:
- Re: [PATCH 1/2]: Refactor relocate_path to also check if the relocated file/directory exists
  - From: Jan Kratochvil

References:
- [PATCH] Try to initialize data-directory by first searching for "data-directory" in the same directory as the gdb binary
  - From: Khoo Yit Phang
- Re: [PATCH] Try to initialize data-directory by first searching for "data-directory" in the same directory as the gdb binary
  - From: Jan Kratochvil
- [PATCH 1/2]: Refactor relocate_path to also check if the relocated file/directory exists
  - From: Khoo Yit Phang
- Re: [PATCH 1/2]: Refactor relocate_path to also check if the relocated file/directory exists
  - From: Jan Kratochvil
- Re: [PATCH 1/2]: Refactor relocate_path to also check if the relocated file/directory exists
  - From: Eli Zaretskii
- Re: [PATCH 1/2]: Refactor relocate_path to also check if the relocated file/directory exists
  - From: Jan Kratochvil
- Re: [PATCH 1/2]: Refactor relocate_path to also check if the relocated file/directory exists
  - From: Andreas Schwab

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]