This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Eliminate local variables to use TYPE_LENGTH directly

From: Siddhesh Poyarekar <siddhesh at redhat dot com>
To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
Cc: gdb-patches at sourceware dot org
Date: Tue, 25 Sep 2012 18:20:11 +0530
Subject: Re: [PATCH] Eliminate local variables to use TYPE_LENGTH directly
References: <20120924173542.625d322c@spoyarek> <20120925082558.GA9305@host2.jankratochvil.net>

On Tue, 25 Sep 2012 10:25:58 +0200, Jan wrote:
> 		ax_const_l (ax, TYPE_LENGTH (value.type));
> 
> 
> (You even did so in s390_value_from_register as I see.)
> 

Yeah, keeping it in there would have changed the program flow.
 
> 
> I see no bugs there, OK for check-in with those few changes.
> 

Committed with your suggested changes:

http://sourceware.org/ml/gdb-cvs/2012-09/msg00142.html

Thanks,
Siddhesh

References:
- [PATCH] Eliminate local variables to use TYPE_LENGTH directly
  - From: Siddhesh Poyarekar
- Re: [PATCH] Eliminate local variables to use TYPE_LENGTH directly
  - From: Jan Kratochvil

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]