This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Include access size in find command error message


On 09/26/2012 06:28 PM, Andrew Burgess wrote:

> I did change the first call on search_buf_size to pulongest as I spotted that it was unsigned.  But other
> than that I've left the code as is.  There seems to be massive precedent for this throughout gdb, so
> in the absence of better suggestions, this seems acceptable.

My suggestion would be to use the appropriate %d/%u.  But as I said, it
doesn't really matter.  As is is fine with me.

I've spotted what looks like a typo, but otherwise, this is OK.  Thanks.

> +    From gdb we can then perform find commands into unmapped region, gdb
> +    should given an error.

"should give"

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]