This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 3/3] Add a test case for the jit-reader interface.

From: Tom Tromey <tromey at redhat dot com>
To: Sanjoy Das <sanjoy at playingwithpointers dot com>
Cc: gdb-patches at sourceware dot org
Date: Tue, 16 Oct 2012 14:15:51 -0600
Subject: Re: [PATCH 3/3] Add a test case for the jit-reader interface.
References: <1349696849-9056-1-git-send-email-sanjoy@playingwithpointers.com> <1349696849-9056-4-git-send-email-sanjoy@playingwithpointers.com>

>>>>> "Sanjoy" == Sanjoy Das <sanjoy@playingwithpointers.com> writes:

Sanjoy> +2012-10-08  Sanjoy Das <sanjoy@playingwithpointers.com>
Sanjoy> +
Sanjoy> +	* gdb.base/jit-reader.exp: New file. Test case for the jit-reader
Sanjoy> +	interface.
Sanjoy> +	* gdb.base/jithost.c: Do.
Sanjoy> +	* gdb.base/jithost.h: Do.
Sanjoy> +	* gdb.base/jitreader.c : Do.

Thanks very much for doing this.

I was concerned that this test should be native-only, but then I noticed
that skip_shlib_tests checks isnative.  So, no worries there.

Sanjoy> +set include_dir ${objdir}/../../

I think this should use standard_output_file.

This patch is ok with this change.

thanks,
Tom

Follow-Ups:
- Re: [PATCH 3/3] Add a test case for the jit-reader interface.
  - From: Pedro Alves

References:
- [PATCH 0/3] Address review, "fix recent breakage in the JIT reader interface"
  - From: Sanjoy Das
- [PATCH 3/3] Add a test case for the jit-reader interface.
  - From: Sanjoy Das

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]