This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: PATCH: PR binutils/14813: Wrong return type for opncls_bclose
- From: Alan Modra <amodra at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Binutils <binutils at sourceware dot org>, GDB <gdb-patches at sourceware dot org>
- Date: Wed, 7 Nov 2012 18:00:48 +1030
- Subject: Re: PATCH: PR binutils/14813: Wrong return type for opncls_bclose
- References: <20121107003007.GA8682@gmail.com> <20121107010714.GQ31965@bubble.grove.modra.org> <CAMe9rOrq7QNfMk6cBtN37TtNHCo-wQ83CbNM9r1GsHqsB8qWCg@mail.gmail.com>
On Tue, Nov 06, 2012 at 09:34:23PM -0800, H.J. Lu wrote:
> On Tue, Nov 6, 2012 at 5:07 PM, Alan Modra <amodra@gmail.com> wrote:
> > On Tue, Nov 06, 2012 at 04:30:07PM -0800, H.J. Lu wrote:
> >> Hi,
> >>
> >> This patch changes return type of bclose to bfd_boolean. It fixes
> >> binutils/bfdtest2. OK to install?
> >
> > Not without checking gdb code too.
> >
>
> Sure. Here is the GDB patch. OK to install?
No, gdb is fine as is. When I saw your change I grepped for bfd_iovec
and hit a number of places in gdb, which is why I commented about
checking gdb. It turns out that none of these have anything to do
with your change to struct bfd_iovec.
--
Alan Modra
Australia Development Lab, IBM