This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [obv] Move macro current_ptid to gdbthread.h and use it


> It is obvious, and I'll commit it in two days.
>
> gdb/gdbserver:
> 
> 2012-11-06  Yao Qi  <yao@codesourcery.com>
> 
> 	* spu-low.c (current_ptid): Move it to ..
> 	* gdbthread.h: ... here.  New.
> 	* remote-utils.c (read_ptid): Use macro 'current_ptid'.
> 	* server.c (myresume, process_serial_event): Likewise.
> 	* thread-db.c (thread_db_find_new_threads): Likewise.
> 	* tracepoint.c (run_inferior_command): Likewise.

Cannot approve, but I noticed a small nit:

> +/* Get current thread ID (Linux task ID).  */
> +#define current_ptid ((struct inferior_list_entry *)current_inferior)->id
                                                       ^
                                                       |
     missing space there   ----------------------------+


-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]