Re: [RFA] Look for system.gdbinit in specified --data-directory

[Doug Evans <dje at google dot com>]

On Thu, Nov 15, 2012 at 10:03 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Thu, 15 Nov 2012 06:29:07 -0800
>> From: Doug Evans <dje@google.com>
>> Cc: palves@redhat.com, gdb-patches@sourceware.org
>>
>> When I wrote:
>>
>> >> Remember, this only happens *if* system.gdbinit lives somewhere
>> >> underneath data-directory.
>>
>> pretend I said:
>>
>> Remember, this only happens *if* the configured location of
>> system.gdbinit (the value of --with-system-gdbinit) is in the
>> configured location of data-directory (the value of
>> --with-gdb-datadir).
>
> Ah, okay, sorry for my misunderstanding.
>
> But why "pretend"?  Why not say this explicitly?

That "pretend" comment was referring to text in the prose of an email
message, not anything intended to appear in a patch.
Yikes.

> Like this, for
> example:
>
>   If the configured location of system.gdbinit file (as given by the
>   --with-system-gdbinit option at configure time) is in the
>   data-directory (as specified by --with-gdb-datadir at configure
>   time) or in one of its subdirectories, then GDB will look for the
>   system-wide init file in the directory specified by the
>   --data-directory command-line option.

Ok to check in?

2012-11-15  Doug Evans  <dje@google.com>

        * main.c (gdb_datadir_provided): New static global.
        (get_init_files): If --data-directory is provided,
        and SYSTEM_GDBINIT lives in data-directory, look for it there.
        * NEWS: Mention it.

        doc/
        * gdb.texinfo (System-wide configuration): If the system-wide init
        file lives in the data-directory, and --data-directory is provided,
        look for it there.

Attachment: gdb-121115-sys-gdbinit-data-dir-3.patch.txt
Description: Text document