This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] use gdbarch_addr_bits_remove for entry point address

From: Pedro Alves <palves at redhat dot com>
To: Yao Qi <yao at codesourcery dot com>
Cc: gdb-patches at sourceware dot org
Date: Mon, 26 Nov 2012 11:57:17 +0000
Subject: Re: [PATCH] use gdbarch_addr_bits_remove for entry point address
References: <1353404184-22073-1-git-send-email-yao@codesourcery.com> <50AFD573.1090601@gmail.com> <50B0ABF9.1080606@codesourcery.com>

This version is OK, but please fix up the ChangeLog entry.

> 2012-11-24  Daniel Jacobowitz  <dan@codesourcery.com>
> 	    Kazu Hirata  <kazu@codesourcery.com>
> 	    Yao Qi  <yao@codesourcery.com>
> 
> 	* objfiles.c (entry_point_address_query): Move some code ...
> 	(init_entry_point_info): ... here.

Please be more specific:

 	* objfiles.c (entry_point_address_query): Call
	gdbarch_convert_from_func_ptr_addr and gdbarch_addr_bits_remove
	here ...
 	(init_entry_point_info): ... instead of here.

That's more useful for archaeology.

> 	* solib-svr4.c (exec_entry_point): Likewise.

"Likewise" here doesn't make sense.  Perhaps:

 	* solib-svr4.c (exec_entry_point): Call gdbarch_addr_bits_remove.

> 	* symfile.c (generic_load): Call gdbarch_addr_bits_remove on
> 	the entry address.

-- 
Pedro Alves

Follow-Ups:
- Re: [PATCH] use gdbarch_addr_bits_remove for entry point address
  - From: Yao Qi

References:
- [PATCH] use gdbarch_addr_bits_remove for entry point address
  - From: Yao Qi
- Re: [PATCH] use gdbarch_addr_bits_remove for entry point address
  - From: Pedro Alves
- Re: [PATCH] use gdbarch_addr_bits_remove for entry point address
  - From: Yao Qi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]