This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Re: [PATCH] Fix for incorect breakpoint set in case of clang compiled binary
- From: KARTHIKVENKATESH BHAT <kv dot bhat at samsung dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Mark Kettenis <mark dot kettenis at xs4all dot nl>, "palves at redhat dot com" <palves at redhat dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 28 Nov 2012 05:14:26 +0000 (GMT)
- Subject: Re: Re: [PATCH] Fix for incorect breakpoint set in case of clang compiled binary
- Dlp-filter: Pass
- Msgkey: 20121128045920937@kv.bhat
- Reply-to: kv dot bhat at samsung dot com
Hi Tom/Mark,
Done. Took care of formatting comments. Any other inputs?
Thanks
------- Original Message -------
Sender : Tom Tromey<tromey@redhat.com>
Date : Nov 28, 2012 00:58 (GMT+09:00)
Title : Re: [PATCH] Fix for incorect breakpoint set in case of clang compiled binary
>>>>> "Karthik" == KARTHIKVENKATESH BHAT writes:
Karthik> Please find the Changes after comments -
There are some formatting issues in the patch.
Karthik> + /* Clang always emits a line note before the prologue and another
Karthik> + one after.We trust clang to emit usable line notes */
Two spaces after the ".".
A "." followed by 2 spaces at the end of the second sentence.
Karthik> + return max(start_pc,post_prologue_pc);
Space before open paren and after the comma.
Tom