This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFC: really free pending_blocks, v2
- From: Tom Tromey <tromey at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 29 Nov 2012 09:18:15 -0700
- Subject: Re: RFC: really free pending_blocks, v2
- References: <87mwy077ny.fsf@fleche.redhat.com> <50B788C4.60707@redhat.com>
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>> +static struct pending_block *pending_blocks;
Pedro> Do we take care of always clearing this before starting a new symtab?
If we don't, then I think it is an existing bug, not affected by this
patch.
But, we do take care. The various symbol readers install
really_free_pendings as a cleanup.
buildsym in general is a mess, mostly because it works using a lot of
globals. It's never been actively bad enough to fix, though -- it came
close with the dwz work, but still managed to dodge a big cleanup.
Tom