This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC-v4] Fix .text section offset for windows DLL (was Calling __stdcall functions in the inferior)
- From: Pedro Alves <palves at redhat dot com>
- To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: "'Joel Brobecker'" <brobecker at adacore dot com>, "'Eli Zaretskii'" <eliz at gnu dot org>, gdb-patches at sourceware dot org
- Date: Fri, 07 Dec 2012 17:50:35 +0000
- Subject: Re: [RFC-v4] Fix .text section offset for windows DLL (was Calling __stdcall functions in the inferior)
- References: <834nm07z0s.fsf@gnu.org> <5077FEB9.4030304@redhat.com> <83y5jb7rfe.fsf@gnu.org> <006001cdaada$00c81f00$02585d00$@muller@ics-cnrs.unistra.fr> <20121024194517.GK3555@adacore.com> <011901cdb2ab$48076b90$d81642b0$@muller@ics-cnrs.unistra.fr> <20121105171121.GA2972@adacore.com> <50991f5f.8382440a.1100.ffff82abSMTPIN_ADDED@mx.google.com> <509ABA17.30507@redhat.com> <000301cdbd96$f5cd9f10$e168dd30$@muller@ics-cnrs.unistra.fr> <20121122173019.GF9964@adacore.com> <50b2a0d1.c849420a.3a3a.3538SMTPIN_ADDED_BROKEN@mx.google.com> <50C21B58.3040904@redhat.com> <000001cdd49c$bba71b50$32f551f0$@muller@ics-cnrs.unistra.fr>
Please don't top post.
On 12/07/2012 05:03 PM, Pierre Muller wrote:
> Hi Pedro,
>
> The values are indeed included in include/coff/pe.h header...
> The problem is that coff-pe-read.c was
> written completely without the use of this
> header.
> Using that header would probably be better,
> but would also require even more rewrite
> of current code...
>
> I tried nevertheless to include coff/pe.h
> I got an error about AOUTHDR not being defined,
> which requires adding coff/external.h
> but if I add that one, I get another error
> that L_LNNO_SIZE must be defined...
> And that one is defined in cpu specific files
> coff/CPU.h
>
> This seems to mean that including pe.h is not that easy :(
Yuck. It'd be nice if the architecture independent
bits of pe.h were split into a separate file, e.g.,
pe-common.h. But I'll agree that this should not be a
requirement for this patch.
But I'm still confused on why do you need "#ifndef IMAGE_SCN_CNT_CODE"
instead of unconditionally defining the constants. What is pulling
a header that defines these?
--
Pedro Alves