This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Make contrib/ari/gdb_find.sh script more configurable


On 12/11/2012 01:01 PM, Pierre Muller wrote:
>     As we were talking about adding 
> gdbserver to the list of directories that should
> also be inspected by Awk regression scripts,
> I propose hereby a patch allowing to include directory
> gdbtk, gdbserver or gnulib to the list of inspected directories
> by simply exporting a variable named check_XXX_dir
> before running the scripts.

IMO, if you're going to support something like this, I think
it'd make more sense to make it a single variable that accepts
a list of dirs, like:

ARI_CHECK_EXTRA_DIRS=gdbtk,gdbserver,gnulib,whatnot

or the CLI version --check-extra-dirs=gdbtk,gdbserver,gnulib,whatnot
or some such.

>From reading the patch, I find no real need to hardcode the set
of possible dirs.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]