This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] allow ravenscar thread support on multiple architectures


On 12/12/2012 02:51 PM, Joel Brobecker wrote:

> Does this look reasonable to you, before I go any further?

It does to me.

Things that stood out on a quick glance:

 - '=' goes on beginning next line.
 - missing space before '(' in current_inferior call, or use
   "target_gdbarch ()" instead.
 - I think this will break non-bare-metal builds as is, because those
   don't include ravenscar-thread.o, etc.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]